-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(en/superstream): enable NSFW & (en/nollyverse): added missing refactor #3064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Secozzi
reviewed
Mar 17, 2024
Secozzi
reviewed
Mar 17, 2024
src/en/superstream/src/eu/kanade/tachiyomi/animeextension/en/superstream/SuperStreamAPI.kt
Outdated
Show resolved
Hide resolved
Secozzi
reviewed
Mar 19, 2024
src/en/superstream/src/eu/kanade/tachiyomi/animeextension/en/superstream/SuperStream.kt
Outdated
Show resolved
Hide resolved
Secozzi
reviewed
Mar 19, 2024
src/en/superstream/src/eu/kanade/tachiyomi/animeextension/en/superstream/SuperStreamAPI.kt
Outdated
Show resolved
Hide resolved
Secozzi
reviewed
Mar 19, 2024
Comment on lines
191
to
192
const val PREF_HIDE_NSFW_KEY = "pref_hide_nsfw" | ||
const val PREF_HIDE_NSFW_DEFAULT = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make these private
Secozzi
reviewed
Mar 19, 2024
|
||
private val client = configureToIgnoreCertificate() | ||
|
||
// 0 to get nsfw | ||
private val hideNsfw = 1 | ||
private val hideNsfw = if (preferences.getBoolean(SuperStream.PREF_HIDE_NSFW_KEY, SuperStream.PREF_HIDE_NSFW_DEFAULT)) 1 else 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create a new val for preferences.hideNsfw
in the SuperStream main class
jmir1
approved these changes
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
extVersionCode
value inbuild.gradle
for individual extensionsoverrideVersionCode
orbaseVersionCode
as needed for all multisrc extensionsisNsfw = true
flag inbuild.gradle
when appropriateid
if a source's name or language were changedweb_hi_res_512.png
when adding a new extension