Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Anime4Up.kt #3029

Closed
wants to merge 17 commits into from
Closed

Update Anime4Up.kt #3029

wants to merge 17 commits into from

Conversation

Amrd12
Copy link

@Amrd12 Amrd12 commented Mar 8, 2024

enable last eps tab and add the fun to filter by season

Checklist:

  • Updated extVersionCode value in build.gradle for individual extensions
  • Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
  • Referenced all related issues in the PR body (e.g. "Closes #xyz")
  • Added the isNsfw = true flag in build.gradle when appropriate
  • Have not changed source names
  • Have explicitly kept the id if a source's name or language were changed
  • Have tested the modifications by compiling and running the extension through Android Studio
  • Have removed web_hi_res_512.png when adding a new extension

enable last eps tab and add the fun to filter by season
@Amrd12
Copy link
Author

Amrd12 commented Mar 9, 2024

please review the extention after modifing
https://github.com/Amrd12/extension-builder/actions/runs/8210417009
and please accept this pull request and the other
#3028
this is my first pull request on project but im happy to do something useful
i added the functionality of last episodes tab and new filtering by season

@Secozzi Secozzi mentioned this pull request Mar 9, 2024
8 tasks
@Secozzi
Copy link
Contributor

Secozzi commented Mar 9, 2024

Follow the checklist

Copy link
Contributor

@Samfun75 Samfun75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also run lint

@@ -211,6 +241,15 @@ class Anime4Up : ConfigurableAnimeSource, ParsedAnimeHttpSource() {
}

// ============================= Utilities ==============================
private inline fun <A, B> Iterable<A>.parallelCatchingFlatMap(crossinline f: suspend (A) -> Iterable<B>): List<B> =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this already in the extension-lib 14? Use that instead of duplicating the code

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import back parallelCatchingFlatMapBlocking and use that one. you have deleted it above

@Amrd12 Amrd12 requested review from Secozzi and Samfun75 March 9, 2024 13:11
@Samfun75
Copy link
Contributor

Samfun75 commented Mar 9, 2024

Have tested the modifications by compiling and running the extension through Android Studio

I don't think you are testing your changes, the pr has syntax errors in it's current state. putting this on draft

@Samfun75 Samfun75 marked this pull request as draft March 9, 2024 17:27
@Secozzi
Copy link
Contributor

Secozzi commented Apr 2, 2024

Closing due to no response, feel free to create a new pull requests when you have addresses the issues and when you have tested your code.

@Secozzi Secozzi closed this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants