refactor: remove BuildConfig from preference keys #3023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Claudemirovsky
changed the title
jmir1
previously approved these changes
Mar 6, 2024
jmir1
reviewed
Mar 6, 2024
src/en/ask4movie/src/eu/kanade/tachiyomi/animeextension/en/ask4movie/Ask4Movie.kt
Outdated
Show resolved
Hide resolved
src/en/ask4movie/src/eu/kanade/tachiyomi/animeextension/en/ask4movie/Ask4Movie.kt
Outdated
Show resolved
Hide resolved
|
Nice timing |
Wtf are you in my walls? |
|
Btw, could you mark affected extensions with a |
|
For the full list you can just look at this pr or search for the comment in the whole project |
|
so how do you solve the "baseurl constantly changing" problem then? waiting for pull get merge again? |
I already explained that in my pull request comment, you shouldn't rely on BuildConfig in the preference keys |
jmir1
approved these changes
Mar 7, 2024
8 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the version number as the key will leave a trail of obsolete preferences, which should be avoided. I don't mean to prevent overridable baseurls with this pr, it's just that they should be implemented in such a way that doesn't create unnecessary preference items. I also don't want to convert all to a new system, since a lot of extension appears to not have changed urls in a long time.