Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(multisrc/aniwatch/kaido): failed to extract video #2711

Closed
wants to merge 3 commits into from
Closed

fix(multisrc/aniwatch/kaido): failed to extract video #2711

wants to merge 3 commits into from

Conversation

KawsarDev
Copy link
Contributor

@KawsarDev KawsarDev commented Jan 8, 2024 •
edited
Loading

fixes #2568
Checklist:

  • Updated extVersionCode value in build.gradle for individual extensions
  • Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
  • Referenced all related issues in the PR body (e.g. "Closes #xyz")
  • Added the containsNsfw = true flag in build.gradle when appropriate
  • Have not changed source names
  • Have explicitly kept the id if a source's name or language were changed
  • Have tested the modifications by compiling and running the extension through Android Studio

@jmir1
Copy link
Member

jmir1 commented Jan 8, 2024

I don't understand, what does @theonlymo 's repo do differently?

@KawsarDev
Copy link
Contributor Author

I don't understand, what does @theonlymo 's repo do differently?

It updates the keys frequently

@KawsarDev KawsarDev marked this pull request as draft January 9, 2024 04:23
@KawsarDev KawsarDev marked this pull request as ready for review January 9, 2024 04:26
@jmir1
Copy link
Member

jmir1 commented Jan 9, 2024

thats insane
it runs every minute

@jmir1
Copy link
Member

jmir1 commented Jan 9, 2024

github free plan only has 2000 minutes included so you're gonna run out of your quota in about a day and a half

@jmir1
Copy link
Member

jmir1 commented Jan 9, 2024

github free plan only has 2000 minutes included so you're gonna run out of your quota in about a day and a half

I have GitHub pro plan

BTW, I didn't know this, but there is no limit for public repositories 👍

@KawsarDev KawsarDev marked this pull request as draft January 9, 2024 13:45
@KawsarDev KawsarDev marked this pull request as ready for review January 9, 2024 16:32
@KawsarDev
Copy link
Contributor Author

@jmir1 can you check this pr

@rebelonion rebelonion mentioned this pull request Jan 11, 2024
Merged
7 tasks
@KawsarDev
Copy link
Contributor Author

#2721 seems better

@KawsarDev KawsarDev closed this Jan 11, 2024
@KawsarDev KawsarDev deleted the fix(multisrc/aniwatch/kaido)-failed-to-extract-video branch January 11, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AniWatch And Kaido: Failed to extract video.
2 participants
@KawsarDev @jmir1