Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(multisrc/animestream/es): New source: AnimeYT.es and Anime.Tiodonghua.com and others fixs #2531

Merged
merged 11 commits into from
Nov 25, 2023
Merged

feat(multisrc/animestream/es): New source: AnimeYT.es and Anime.Tiodonghua.com and others fixs #2531

merged 11 commits into from
Nov 25, 2023

Conversation

Dark25
Copy link
Contributor

@Dark25 Dark25 commented Nov 20, 2023 •
edited by Claudemirovsky
Loading

Checklist:

  • Updated extVersionCode value in build.gradle for individual extensions
  • Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
  • Have not changed source names
  • Have explicitly kept the id if a source's name or language were changed
  • Have tested the modifications by compiling and running the extension through Android Studio

thank claudemirovsky

@Dark25 Dark25 changed the title feat(multisrc/animestream/es): New source: AnimeYT.es feat(multisrc/animestream/es): New source: AnimeYT.es and Anime.Tiodonghua.com Nov 21, 2023
@Dark25 Dark25 changed the title feat(multisrc/animestream/es): New source: AnimeYT.es and Anime.Tiodonghua.com feat(multisrc/animestream/es): New source: AnimeYT.es and Anime.Tiodonghua.com and fix EnNovelas Nov 21, 2023
@Dark25
Copy link
Contributor Author

Dark25 commented Nov 21, 2023 •
edited
Loading

pull ready for merge

@Dark25 Dark25 changed the title feat(multisrc/animestream/es): New source: AnimeYT.es and Anime.Tiodonghua.com and fix EnNovelas feat(multisrc/animestream/es): New source: AnimeYT.es and Anime.Tiodonghua.com and others fixs Nov 21, 2023
@Dark25
Copy link
Contributor Author

Dark25 commented Nov 21, 2023 •
edited
Loading

Animes Vision #2533 Close, change domain base for fix error 505

Now it's finished xD

Claudemirovsky
Claudemirovsky requested changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@Claudemirovsky Claudemirovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice first contribution bro! There's just a few minor issues, but they're all easy to fix.

multisrc/overrides/animestream/animeytes/src/AnimeYTES.kt Outdated Show resolved Hide resolved
multisrc/overrides/animestream/tiodonghua/src/Tiodonghua.kt Outdated Show resolved Hide resolved
multisrc/overrides/animestream/tiodonghua/src/Tiodonghua.kt Outdated Show resolved Hide resolved
multisrc/overrides/animestream/tiodonghua/src/Tiodonghua.kt Outdated Show resolved Hide resolved
@jmir1
Copy link
Member

jmir1 commented Nov 24, 2023

Also please delete all the foreground, background, monochrome and xml launcher files. Only the ic_launcher.png file is needed. (See other sources)

@Dark25
Copy link
Contributor Author

Dark25 commented Nov 24, 2023

Ready 🗡️

@jmir1 jmir1 requested review from Claudemirovsky and removed request for Claudemirovsky November 24, 2023 23:35
Claudemirovsky
Claudemirovsky approved these changes Nov 25, 2023
View reviewed changes
Copy link
Contributor

@Claudemirovsky Claudemirovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10/10 LGTM

@jmir1 jmir1 merged commit 1750b3d into aniyomiorg:master Nov 25, 2023
5 checks passed
@Leviasem

This comment was marked as spam.

Sign in to view
@Leviasem

This comment was marked as spam.

Sign in to view
@aniyomiorg aniyomiorg temporarily blocked Leviasem Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Claudemirovsky Claudemirovsky Claudemirovsky approved these changes

@jmir1 jmir1 jmir1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Dark25 @jmir1 @Leviasem @Claudemirovsky