Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lib/googledrive-extractor): (hopefully) improve extraction #2327

Merged
merged 2 commits into from
Oct 8, 2023
Merged

feat(lib/googledrive-extractor): (hopefully) improve extraction #2327

merged 2 commits into from
Oct 8, 2023

Conversation

Secozzi
Copy link
Contributor

@Secozzi Secozzi commented Oct 7, 2023

Hopefully fixes the "unrecognized file format" bug, but due to its very nature its not really possible to test it.

Checklist:

  • Updated extVersionCode value in build.gradle for individual extensions
  • Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
  • Referenced all related issues in the PR body (e.g. "Closes #xyz")
  • Added the isNsfw = true flag in build.gradle when appropriate
  • Have not changed source names
  • Have explicitly kept the id if a source's name or language were changed
  • Have tested the modifications by compiling and running the extension through Android Studio

@Secozzi Secozzi marked this pull request as draft October 7, 2023 18:46
@Secozzi Secozzi marked this pull request as ready for review October 7, 2023 18:58
@jmir1 jmir1 merged commit d0f675c into master Oct 8, 2023
@jmir1 jmir1 deleted the gdriveextractor branch October 8, 2023 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmir1 jmir1 jmir1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Secozzi @jmir1