Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(all/googledrive): improve fetching of details #2324

Merged
merged 2 commits into from
Oct 7, 2023
Merged

Conversation

Secozzi
Copy link
Contributor

@Secozzi Secozzi commented Oct 7, 2023

Instead of iterating over every single item in the folder, it will now search for a "cover" image thus reducing the number of requests needed. Also added support for a details.json file as well.

Checklist:

  • Updated extVersionCode value in build.gradle for individual extensions
  • Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
  • Referenced all related issues in the PR body (e.g. "Closes #xyz")
  • Added the isNsfw = true flag in build.gradle when appropriate
  • Have not changed source names
  • Have explicitly kept the id if a source's name or language were changed
  • Have tested the modifications by compiling and running the extension through Android Studio

@jmir1 jmir1 merged commit e00a845 into master Oct 7, 2023
5 checks passed
@jmir1 jmir1 deleted the gdrivedetails branch October 7, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants