Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.12 #346

Merged
merged 3 commits into from
Sep 10, 2023
Merged

Conversation

kurtmckee
Copy link
Contributor

All tests pass under Python 3.12 already, but the test suite was using a shutil.rmtree option, onerror, that Python 3.12 introduced a replacement for (onexc) and simultaneously deprecated.

This is addressed, pytest is now configured to escalate warnings into errors, and the test suite -- and CI -- have been updated to include Python 3.12 in their runs.

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (840cd16) 89.13% compared to head (26720b8) 89.14%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #346      +/-   ##
==========================================
+ Coverage   89.13%   89.14%   +0.01%     
==========================================
  Files          33       33              
  Lines        1620     1622       +2     
  Branches      306      307       +1     
==========================================
+ Hits         1444     1446       +2     
  Misses        124      124              
  Partials       52       52              
Files Changed Coverage Δ
tests/conftest.py 92.35% <100.00%> (+0.09%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anishathalye anishathalye merged commit 3f9e409 into anishathalye:master Sep 10, 2023
22 checks passed
@anishathalye
Copy link
Owner

Thank you!

@kurtmckee kurtmckee deleted the support-python-3.12 branch September 10, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants