Skip to content

Commit

Permalink
vttestserver should only pass a BindAddressGprc if one is passed in. …
Browse files Browse the repository at this point in the history
…If none is passed in, it should pass nothing causing gRPC port to be bound to all interfaces (instead of just 127.0.0.1).

Fixes vitessio#17396

Signed-off-by: Anirban Mukhopadhyay <[email protected]>
  • Loading branch information
anirbanmu committed Jan 3, 2025
1 parent b8b0383 commit ee5b634
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion go/vt/vttest/vtprocess.go
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ func VtcomboProcess(environment Environment, args *Config, mysql MySQLManager) (
if args.VtComboBindAddress != "" {
vtcomboBindAddress = args.VtComboBindAddress
}
grpcBindAddress := "127.0.0.1"
grpcBindAddress := ""
if servenv.GRPCBindAddress() != "" {
grpcBindAddress = servenv.GRPCBindAddress()
}
Expand Down

0 comments on commit ee5b634

Please sign in to comment.