Google's native Universal Analytics plugin for cordova apps #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't use cordova/ionic. Can this potentially replace the existing plugin? Also, thanks for the PR! |
|
Yes this is replacement for existing plugin |
|
+1 The build/GAPlugin does not seem to be getting love. I would also like to see the danwilson or cmackay GA plugin become the default Cordova provider. I have no preference which. https://github.com/sullivanpt/angulartics-ga-cordova-cmackay |
|
@heks thanks for the great work. Unfortunately I missed your PR and merged another one that should work the same way https://github.com/luisfarzati/angulartics/pull/259 (using Dan Wilson's plugin) Does this fit your needs? |
|
Hey, feel free to reopen if #259 didn't help you and we can discuss it further. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin uses danwilson's google-analytics plugin ( https://github.com/danwilson/google-analytics-plugin ) with angulartics. This is great for ionic/cordova hybrid apps as the other angulartics-ga-cordova plugin uses an outdated plugin (https://github.com/phonegap-build/GAPlugin) which throws errors on newer versions of cordova.