Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed some parameters on directive to make their values dynamic. #63

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

willian
Copy link

@willian willian commented Dec 8, 2014

In my app I have 3 environments: development, staging and production. Is common to have something like this, and use environment variables or a configuration file per environment to manage some data, like services API's IDs, secrets keys, etc.

Passing only string

<oauth site="https://instagram.com"
       client-id="'some-id'"
       redirect-uri="'http://example.com/callback/instagram'"
       scope="basic"
       text="Connect Instagram">
</oauth>

Using an object

<oauth site="https://instagram.com"
       client-id="OAuthInfo.instagramAppID"
       redirect-uri="OAuthInfo.redirectURL + '/instagram'"
       scope="basic"
       text="Connect Instagram">
</oauth>

Because of that I changed some parameters to allow me to send a object/variable instead of a plain string.

For now I'm using my own repository, but would be nice to use the original again.

Please, let me know your thoughts about this PR.

@andreareginato
Copy link
Collaborator

Would be great to have the following:

  • tests with strings and variables
  • docs on gh-pages

Can you make it @willian?

@andreareginato
Copy link
Collaborator

Any possibility to have a test suite on this @willian? It would be really a really nice to have feature.

@MikeSam
Copy link

MikeSam commented Jul 1, 2015

+1 for parameters on directive

@bramski
Copy link
Member

bramski commented Jun 29, 2016

Poke @willian. This PR should be closed otherwise. It's looking rather ancient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants