Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(select): optgroups are not visible to screen readers #11771

Merged
merged 1 commit into from
May 15, 2020

Conversation

Splaktar
Copy link
Member

@Splaktar Splaktar commented Aug 8, 2019

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Option groups are not read by screen readers.

Issue Number:
#11240

What is the new behavior?

Option groups are read by screen readers without breaking the reading of indexes.

  • add single selection optgroup demo
  • add tests for optgroup aria-label
  • add tests for optgroup options' aria-setsize and aria-posinset

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

On VoiceOver for macOS, indexes are no longer announced if md-optgroups are used but it's probably better to have the groups announced than to worry about indexes being announced.

For ChromeVox, both the option groups and indexes are announced properly.

This PR is based on PR #11761 and can't be merged or presubmitted until that PR is merged and sync'd.

@Splaktar Splaktar self-assigned this Aug 8, 2019
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Aug 8, 2019
@Splaktar Splaktar added Blocked Progress on this issue is blocked. Primarily used for PRs that are blocked by presubmit feedback. g3: sync P2: required Issues that must be fixed. type: bug a11y This issue is related to accessibility g3: reported The issue was reported by an internal or external product team. labels Aug 8, 2019
@Splaktar Splaktar added this to the 1.1.21 milestone Aug 8, 2019
@Splaktar Splaktar requested a review from jelbourn August 8, 2019 23:16
@Splaktar Splaktar force-pushed the select-optGroupsA11y branch from d07d693 to a46310e Compare August 12, 2019 22:31
@Splaktar Splaktar modified the milestones: 1.1.21, 1.1.22 Aug 15, 2019
@Splaktar Splaktar modified the milestones: 1.1.22, 1.1.23 Oct 22, 2019
@Splaktar Splaktar removed the Blocked Progress on this issue is blocked. Primarily used for PRs that are blocked by presubmit feedback. label May 15, 2020
add single selection optgroup demo
add tests for optgroup `aria-label`
add tests for optgroup options' `aria-setsize` and `aria-posinset`

Fixes #11240
@Splaktar Splaktar force-pushed the select-optGroupsA11y branch from a46310e to 2cc614f Compare May 15, 2020 02:22
@Splaktar Splaktar requested a review from mmalerba May 15, 2020 02:24
@Splaktar Splaktar added the pr: merge ready This PR is ready for a caretaker to review label May 15, 2020
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splaktar Splaktar added the pr: lgtm This PR has been approved by the reviewer label May 15, 2020
@Splaktar Splaktar merged commit 5fbabe7 into master May 15, 2020
@Splaktar Splaktar deleted the select-optGroupsA11y branch May 15, 2020 18:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11y This issue is related to accessibility cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ g3: reported The issue was reported by an internal or external product team. P2: required Issues that must be fixed. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants