This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(select): optgroups are not visible to screen readers #11771
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Option groups are not read by screen readers.
Issue Number:
#11240
What is the new behavior?
Option groups are read by screen readers without breaking the reading of indexes.
aria-label
aria-setsize
andaria-posinset
Does this PR introduce a breaking change?
Other information
On VoiceOver for macOS, indexes are no longer announced if
md-optgroup
s are used but it's probably better to have the groups announced than to worry about indexes being announced.For ChromeVox, both the option groups and indexes are announced properly.
This PR is based on PR #11761 and can't be merged or presubmitted until that PR is merged and sync'd.