Revert "fix(onStart): Remove stop propagation call so events will bub…

…ble up (#612)" This reverts commit 65a7fae.
angular-slider · Mar 30, 2018 · dacb898 · dacb898
1 parent a1ba079
commit dacb898
Show file tree

Hide file tree

Showing 10 changed files with 465 additions and 431 deletions.
diff --git a/dist/rzslider.css b/dist/rzslider.css
diff --git a/dist/rzslider.js b/dist/rzslider.js
diff --git a/dist/rzslider.min.css b/dist/rzslider.min.css
diff --git a/dist/rzslider.min.js b/dist/rzslider.min.js
diff --git a/dist/rzslider.scss b/dist/rzslider.scss
diff --git a/src/rzslider.js b/src/rzslider.js
@@ -1953,6 +1953,7 @@
             ehEnd,
             eventNames = this.getEventNames(event)
 
+          event.stopPropagation()
           event.preventDefault()
 
           // We have to do this in case the HTML where the sliders are on

diff --git a/tests/specs/mouse-controls/range-slider-horizontal-test.js b/tests/specs/mouse-controls/range-slider-horizontal-test.js
@@ -46,6 +46,7 @@
       helper.slider.callOnStart.called.should.be.true
       helper.slider.focusElement.calledWith(helper.slider.minH).should.be.true
       event.preventDefault.called.should.be.true
+      event.stopPropagation.called.should.be.true
       expect(helper.slider.tracking).to.equal('lowValue')
       expect(helper.slider.minH.hasClass('rz-active')).to.be.true
     })
@@ -64,6 +65,7 @@
       helper.slider.callOnStart.called.should.be.true
       helper.slider.focusElement.called.should.be.false
       event.preventDefault.called.should.be.true
+      event.stopPropagation.called.should.be.true
       expect(helper.slider.tracking).to.equal('lowValue')
       expect(helper.slider.minH.hasClass('rz-active')).to.be.true
     })
@@ -79,6 +81,7 @@
       helper.slider.callOnStart.called.should.be.true
       helper.slider.focusElement.calledWith(helper.slider.maxH).should.be.true
       event.preventDefault.called.should.be.true
+      event.stopPropagation.called.should.be.true
       expect(helper.slider.tracking).to.equal('highValue')
       expect(helper.slider.maxH.hasClass('rz-active')).to.be.true
     })
@@ -97,6 +100,7 @@
       helper.slider.callOnStart.called.should.be.true
       helper.slider.focusElement.called.should.be.false
       event.preventDefault.called.should.be.true
+      event.stopPropagation.called.should.be.true
       expect(helper.slider.tracking).to.equal('highValue')
       expect(helper.slider.maxH.hasClass('rz-active')).to.be.true
     })
@@ -308,6 +312,7 @@
       helper.slider.callOnStart.called.should.be.true
       helper.slider.focusElement.calledWith(helper.slider.minH).should.be.true
       event.preventDefault.called.should.be.true
+      event.stopPropagation.called.should.be.true
       expect(helper.slider.tracking).to.equal('lowValue')
       expect(helper.slider.minH.hasClass('rz-active')).to.be.true
     })
@@ -326,6 +331,7 @@
       helper.slider.callOnStart.called.should.be.true
       helper.slider.focusElement.called.should.be.false
       event.preventDefault.called.should.be.true
+      event.stopPropagation.called.should.be.true
       expect(helper.slider.tracking).to.equal('lowValue')
       expect(helper.slider.minH.hasClass('rz-active')).to.be.true
     })
@@ -341,6 +347,7 @@
       helper.slider.callOnStart.called.should.be.true
       helper.slider.focusElement.calledWith(helper.slider.maxH).should.be.true
       event.preventDefault.called.should.be.true
+      event.stopPropagation.called.should.be.true
       expect(helper.slider.tracking).to.equal('highValue')
       expect(helper.slider.maxH.hasClass('rz-active')).to.be.true
     })
@@ -359,6 +366,7 @@
       helper.slider.callOnStart.called.should.be.true
       helper.slider.focusElement.called.should.be.false
       event.preventDefault.called.should.be.true
+      event.stopPropagation.called.should.be.true
       expect(helper.slider.tracking).to.equal('highValue')
       expect(helper.slider.maxH.hasClass('rz-active')).to.be.true
     })

diff --git a/tests/specs/mouse-controls/range-slider-vertical-test.js b/tests/specs/mouse-controls/range-slider-vertical-test.js
@@ -47,6 +47,7 @@
       helper.slider.callOnStart.called.should.be.true
       helper.slider.focusElement.calledWith(helper.slider.minH).should.be.true
       event.preventDefault.called.should.be.true
+      event.stopPropagation.called.should.be.true
       expect(helper.slider.tracking).to.equal('lowValue')
       expect(helper.slider.minH.hasClass('rz-active')).to.be.true
     })
@@ -65,6 +66,7 @@
       helper.slider.callOnStart.called.should.be.true
       helper.slider.focusElement.called.should.be.false
       event.preventDefault.called.should.be.true
+      event.stopPropagation.called.should.be.true
       expect(helper.slider.tracking).to.equal('lowValue')
       expect(helper.slider.minH.hasClass('rz-active')).to.be.true
     })
@@ -80,6 +82,7 @@
       helper.slider.callOnStart.called.should.be.true
       helper.slider.focusElement.calledWith(helper.slider.maxH).should.be.true
       event.preventDefault.called.should.be.true
+      event.stopPropagation.called.should.be.true
       expect(helper.slider.tracking).to.equal('highValue')
       expect(helper.slider.maxH.hasClass('rz-active')).to.be.true
     })
@@ -98,6 +101,7 @@
       helper.slider.callOnStart.called.should.be.true
       helper.slider.focusElement.called.should.be.false
       event.preventDefault.called.should.be.true
+      event.stopPropagation.called.should.be.true
       expect(helper.slider.tracking).to.equal('highValue')
       expect(helper.slider.maxH.hasClass('rz-active')).to.be.true
     })
@@ -302,6 +306,7 @@
       helper.slider.callOnStart.called.should.be.true
       helper.slider.focusElement.calledWith(helper.slider.minH).should.be.true
       event.preventDefault.called.should.be.true
+      event.stopPropagation.called.should.be.true
       expect(helper.slider.tracking).to.equal('lowValue')
       expect(helper.slider.minH.hasClass('rz-active')).to.be.true
     })
@@ -320,6 +325,7 @@
       helper.slider.callOnStart.called.should.be.true
       helper.slider.focusElement.called.should.be.false
       event.preventDefault.called.should.be.true
+      event.stopPropagation.called.should.be.true
       expect(helper.slider.tracking).to.equal('lowValue')
       expect(helper.slider.minH.hasClass('rz-active')).to.be.true
     })
@@ -335,6 +341,7 @@
       helper.slider.callOnStart.called.should.be.true
       helper.slider.focusElement.calledWith(helper.slider.maxH).should.be.true
       event.preventDefault.called.should.be.true
+      event.stopPropagation.called.should.be.true
       expect(helper.slider.tracking).to.equal('highValue')
       expect(helper.slider.maxH.hasClass('rz-active')).to.be.true
     })
@@ -353,6 +360,7 @@
       helper.slider.callOnStart.called.should.be.true
       helper.slider.focusElement.called.should.be.false
       event.preventDefault.called.should.be.true
+      event.stopPropagation.called.should.be.true
       expect(helper.slider.tracking).to.equal('highValue')
       expect(helper.slider.maxH.hasClass('rz-active')).to.be.true
     })

diff --git a/tests/specs/mouse-controls/single-slider-horizontal-test.js b/tests/specs/mouse-controls/single-slider-horizontal-test.js
@@ -45,6 +45,7 @@
       helper.slider.callOnStart.called.should.be.true
       helper.slider.focusElement.calledWith(helper.slider.minH).should.be.true
       event.preventDefault.called.should.be.true
+      event.stopPropagation.called.should.be.true
       expect(helper.slider.tracking).to.equal('lowValue')
       expect(helper.slider.minH.hasClass('rz-active')).to.be.true
     })
@@ -63,6 +64,7 @@
       helper.slider.callOnStart.called.should.be.true
       helper.slider.focusElement.called.should.be.false
       event.preventDefault.called.should.be.true
+      event.stopPropagation.called.should.be.true
       expect(helper.slider.tracking).to.equal('lowValue')
       expect(helper.slider.minH.hasClass('rz-active')).to.be.true
     })
@@ -247,6 +249,7 @@
       helper.slider.callOnStart.called.should.be.true
       helper.slider.focusElement.calledWith(helper.slider.minH).should.be.true
       event.preventDefault.called.should.be.true
+      event.stopPropagation.called.should.be.true
       expect(helper.slider.tracking).to.equal('lowValue')
       expect(helper.slider.minH.hasClass('rz-active')).to.be.true
     })
@@ -265,6 +268,7 @@
       helper.slider.callOnStart.called.should.be.true
       helper.slider.focusElement.called.should.be.false
       event.preventDefault.called.should.be.true
+      event.stopPropagation.called.should.be.true
       expect(helper.slider.tracking).to.equal('lowValue')
       expect(helper.slider.minH.hasClass('rz-active')).to.be.true
     })

diff --git a/tests/specs/mouse-controls/single-slider-vertical-test.js b/tests/specs/mouse-controls/single-slider-vertical-test.js
@@ -46,6 +46,7 @@
       helper.slider.callOnStart.called.should.be.true
       helper.slider.focusElement.calledWith(helper.slider.minH).should.be.true
       event.preventDefault.called.should.be.true
+      event.stopPropagation.called.should.be.true
       expect(helper.slider.tracking).to.equal('lowValue')
       expect(helper.slider.minH.hasClass('rz-active')).to.be.true
     })
@@ -64,6 +65,7 @@
       helper.slider.callOnStart.called.should.be.true
       helper.slider.focusElement.called.should.be.false
       event.preventDefault.called.should.be.true
+      event.stopPropagation.called.should.be.true
       expect(helper.slider.tracking).to.equal('lowValue')
       expect(helper.slider.minH.hasClass('rz-active')).to.be.true
     })
@@ -266,6 +268,7 @@
       helper.slider.callOnStart.called.should.be.true
       helper.slider.focusElement.calledWith(helper.slider.minH).should.be.true
       event.preventDefault.called.should.be.true
+      event.stopPropagation.called.should.be.true
       expect(helper.slider.tracking).to.equal('lowValue')
       expect(helper.slider.minH.hasClass('rz-active')).to.be.true
     })
@@ -284,6 +287,7 @@
       helper.slider.callOnStart.called.should.be.true
       helper.slider.focusElement.called.should.be.false
       event.preventDefault.called.should.be.true
+      event.stopPropagation.called.should.be.true
       expect(helper.slider.tracking).to.equal('lowValue')
       expect(helper.slider.minH.hasClass('rz-active')).to.be.true
     })