Skip to content

Commit

Permalink
contracts-bedrock: remove typescript (ethereum-optimism#11340)
Browse files Browse the repository at this point in the history
* contracts-bedrock: remove typescript

Moves to using Go from typescript, new code is autogenerated
by claude. Can confirm that both work as expected.

The `check-test-names` is not running in CI, it fails for both
the Go and Typescript scripts. Maybe claude will be able to get
the script to pass.

* Update check-spacers.go

Co-authored-by: semgrep-app[bot] <63493438+semgrep-app[bot]@users.noreply.github.com>

* Update packages/contracts-bedrock/scripts/checks/check-test-names.go

Co-authored-by: semgrep-app[bot] <63493438+semgrep-app[bot]@users.noreply.github.com>

* contracts-bedrock: fix build

* scripts: rename

* scripts: rename

* scripts: fixes

---------

Co-authored-by: protolambda <[email protected]>
Co-authored-by: semgrep-app[bot] <63493438+semgrep-app[bot]@users.noreply.github.com>
  • Loading branch information
3 people authored Aug 3, 2024
1 parent 4c9811f commit 5e31737
Show file tree
Hide file tree
Showing 5 changed files with 342 additions and 284 deletions.
4 changes: 2 additions & 2 deletions packages/contracts-bedrock/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,14 @@
"snapshots:check": "./scripts/checks/check-snapshots.sh",
"semver-lock": "forge script scripts/SemverLock.s.sol",
"validate-deploy-configs": "./scripts/checks/check-deploy-configs.sh",
"validate-spacers:no-build": "npx tsx scripts/checks/check-spacers.ts",
"validate-spacers:no-build": "go run ./scripts/checks/spacers",
"validate-spacers": "pnpm build && pnpm validate-spacers:no-build",
"clean": "rm -rf ./artifacts ./forge-artifacts ./cache ./tsconfig.tsbuildinfo ./tsconfig.build.tsbuildinfo ./scripts/go-ffi/go-ffi ./.testdata ./deployments/hardhat/*",
"pre-pr:no-build": "pnpm gas-snapshot:no-build && pnpm snapshots && pnpm semver-lock && pnpm autogen:invariant-docs && pnpm lint",
"pre-pr": "pnpm clean && pnpm build:go-ffi && pnpm build && pnpm pre-pr:no-build",
"pre-pr:full": "pnpm test && pnpm validate-deploy-configs && pnpm validate-spacers && pnpm pre-pr",
"lint:ts:check": "eslint . --max-warnings=0",
"lint:forge-tests:check": "npx tsx scripts/checks/check-test-names.ts",
"lint:forge-tests:check": "go run ./scripts/checks/names",
"lint:contracts:check": "pnpm lint:fix && git diff --exit-code",
"lint:check": "pnpm lint:contracts:check && pnpm lint:ts:check",
"lint:ts:fix": "eslint --fix .",
Expand Down
152 changes: 0 additions & 152 deletions packages/contracts-bedrock/scripts/checks/check-spacers.ts

This file was deleted.

130 changes: 0 additions & 130 deletions packages/contracts-bedrock/scripts/checks/check-test-names.ts

This file was deleted.

Loading

0 comments on commit 5e31737

Please sign in to comment.