Add SearchPages #88
Merged
Add SearchPages #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fine for me :) Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This starts to implement the changes for #55.
It doesn't run concurrently yet, but I believe this implementation can be made concurrent later. Implementing concurrency is a bit more complicated and I have a few things to consider.
I think we should be careful to not call
ffrom more than one goroutine. Otherwise, the user will need to ensure they are processing the results in a thread safe manner. I also think it is important to maintain the order the issues are returned.With these two constraints, the concurrent implementation will certainly add quite a bit of complexity, so I hope this is good for now.