GCP: Set Custom-Time in cached entries #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This adds an extra HTTP call for every cache hit, this sounds like it will negatively affect the performance. It seems that rerunning a task that had expired the cache based on creation time is a somewhat reasonable approach does not penalize every cache hit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the custom-time when adding or creating a cache entry, which will allow for a more optimal expiration policy.
Resolves #47
I'm not sure how to test this. Please could you help?
I also tidied up a few bits and pieces. E.g. formatting exception messages so they don't have newlines in the middle of the message, and using newer Kotlin features. Please let me know if this is a problem, and I should move them to another PR!