Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better offline support in AWS implementation #44

Merged
merged 3 commits into from
Feb 9, 2024

Conversation

oheyadam
Copy link
Contributor

@oheyadam oheyadam commented Feb 8, 2024

We found that the S3 Amazon clint throws runtime exceptions when you attempt to instantiate it while your machine is offline. This always happens at the entry point validateConfiguration(), so we're going to catch exceptions thrown there and warn about them. Also wraps the delete() operation in a try catch block

@oheyadam oheyadam marked this pull request as draft February 8, 2024 17:22
@oheyadam oheyadam marked this pull request as ready for review February 8, 2024 17:28
@liutikas liutikas merged commit ff6ef9c into androidx:main Feb 9, 2024
2 checks passed
@oheyadam oheyadam deleted the better-offline-support branch February 10, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants