[pull] master from flutter:master #1440
Open
+4,767
−943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Contributes to #130459 It adds a test for `examples/api/test/material/bottom_app_bar/bottom_app_bar.1_test.dart` and `examples/api/test/material/bottom_app_bar/bottom_app_bar.2_test.dart` This are tests of snippets used in [AutofillGroup class](https://api.flutter.dev/flutter/widgets/AutofillGroup-class.html)
Follow up to #157132 I stopped using this string but didn't delete it.
This property would previously have been used by https://github.com/flutter/engine/blob/ad9e4fef451a73427285826455db5fbdde502bd7/shell/platform/android/io/flutter/app/FlutterActivityDelegate.java#L59C31-L59C58 but isn't used by the new `FlutterActivityAndFragmentDelegate`. It's also recommended to be removed by the original v1->v2 updating guide: https://github.com/flutter/flutter/blob/master/docs/platforms/android/Upgrading-pre-1.12-Android-projects.md
Contributes to #130459 It adds a test for - `examples/api/test/material/flexible_space_bar/flexible_space_bar.0_test.dart`
…156778) (Hopefully) fixes #156700 To summarize that thread, there are a few ways to trigger cleanup logic in `flutter run -d chrome`. For example, pressing `q` will close Chrome, but Chrome closing triggers cleanup logic in the resident runner (which includes trying to close Chrome, which is redundant). A simple way to fix this is to not call `Chrome.close` in `ChromiumDevice.stopApp` when we've already called it once. This solution isn't ideal—consider a scenario where two calls to `stopApp` are made concurrently. The second one would probably complete before the browser is actually closed. However, I don't foresee anything ever depending on `stopApp` finishing implying that the browser is closed. I feel like there might be a yak to shave here (`ResidentWebRunner` could keep track of its state and not initiate redundant cleanup operations), but I am not sure its worth the continued effort. <details> <summary> Pre-launch checklist </summary> - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. </details> <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
There have been various requests for this for a while. See #96283 for an example. This has become more important with dart2wasm builds in the mix, as the profiling versions of the dart2wasm builds are a lot less debuggable than the debug versions. Most of this is already wired up so it just requires taking out a few explicit checks for it and making sure that we compile with the right optimization levels when compiling debug.
#157196) We have a group of tests that verifies that we can build a flutter app across the range of AGP, Kotlin, and Gradle versions we claim to support. They currently only run on postsubmit. This pr aims to make them run in presubmit as well, but only when changes are made to the templates (not just android templates, see #157196 (comment) as to why).
…157246) flutter/engine@53e187a...68f9225 2024-10-20 [email protected] [Impeller] New impeller round rect class (flutter/engine#55946) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Replaces `SizedBox`es with the new `spacing` parameter in `Column` and fixes some minor formatting issues. This is a refactoring with no semantic changes. I will get a test exemption.
Adds `onTapUpOutside` and `onTapUpInside` callbacks to `TapRegion`, and `onTapUpOutside` to `EditableText` text fields. This allows users to detect `PointerUpEvent`s, which in turn can be used to differentiate between a tap and pan / scroll gesture (for example by comparing the distance between the down and up events). Fixes #140271 and potentially #138190
flutter/packages@2a1c477...b6f7e47 2024-10-21 49699333+dependabot[bot]@users.noreply.github.com [path_provider]: Bump androidx.annotation:annotation from 1.8.2 to 1.9.0 in /packages/path_provider/path_provider_android/android (flutter/packages#7895) 2024-10-18 [email protected] [in_app_purchase] Update iOS Pigeon for non-nullable generics (flutter/packages#7820) 2024-10-18 [email protected] [interactive_media_ads] Adds internal wrapper for Android native `Ad` (flutter/packages#7880) 2024-10-18 [email protected] [video_player] Remove Android API 19 SSL handling (flutter/packages#7876) 2024-10-18 [email protected] [google_maps_android_flutter] Convert `Config.sdk` to `minSdk` in Robolectric tests and lower to `LOLLIPOP` (flutter/packages#7805) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…MenuController.close()` (#156588) Fixes [Closing a menu controller that was never attached throws an assertion error](#156572) ### Code sample <details> <summary>expand to view the code sample</summary> ```dart import 'package:flutter/material.dart'; void main() => runApp(const MyApp()); class MyApp extends StatelessWidget { const MyApp({super.key}); @OverRide Widget build(BuildContext context) { return MaterialApp( title: 'Flutter Demo', theme: ThemeData( colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple), useMaterial3: true, ), home: const MyHomePage(), ); } } class MyHomePage extends StatefulWidget { const MyHomePage({super.key}); @OverRide State<MyHomePage> createState() => _MyHomePageState(); } class _MyHomePageState extends State<MyHomePage> { @OverRide Widget build(BuildContext context) { return Scaffold( body: Center( child: ElevatedButton( onPressed: () => Navigator.of(context).push( MaterialPageRoute( builder: (context) => const MenuControllerPage(), ), ), child: const Text('Press Me'), ), ), ); } } class MenuControllerPage extends StatefulWidget { const MenuControllerPage({super.key}); @OverRide State<MenuControllerPage> createState() => _MenuControllerPageState(); } class _MenuControllerPageState extends State<MenuControllerPage> { // This menu controller is intentionally left as not attached to a MenuAnchor. final MenuController _menuController = MenuController(); @OverRide void dispose() { // Close the menu when the page is popped. _menuController.close(); super.dispose(); } @OverRide Widget build(BuildContext context) { return Scaffold( body: Center( child: ElevatedButton( child: const Text('Go back'), onPressed: () => Navigator.of(context).pop(), ), ), ); } } ``` </details>
…157277) flutter/engine@68f9225...1a8ef6e 2024-10-21 [email protected] Request another frame in ImageReaderSurfaceProducer.dequeueImage if more images are pending in the queue (flutter/engine#55944) 2024-10-21 [email protected] Roll Dart SDK from c8659684d34d to 10387c3fc6d4 (1 revision) (flutter/engine#55987) 2024-10-21 [email protected] [web] Support woff2 fonts (flutter/engine#55908) 2024-10-21 [email protected] Roll Fuchsia Linux SDK from PWz1ufnYNOGpgw-qg... to avSAUwQTf5xVGuZQU... (flutter/engine#55985) 2024-10-21 [email protected] Manual roll Dart SDK from a51df90298ca to c8659684d34d (4 revisions) (flutter/engine#55984) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from PWz1ufnYNOGp to avSAUwQTf5xV If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…157284) flutter/engine@1a8ef6e...315540e 2024-10-21 [email protected] Increase timeout for Linux mac_clangd (flutter/engine#55988) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Document the requirements for adding a new external, client-facing dependency in flutter/packages
…157290) flutter/engine@315540e...de569ba 2024-10-21 [email protected] re-land "update the repo references for package:file (#55906)" (flutter/engine#55935) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Flutter no longer supports versions of Dart that will output the non-reified version.
…e flutter.groovy (#157221) see #147122 for context [gradle docs](https://docs.gradle.org/current/userguide/task_configuration_avoidance.html) for reference(scroll until [this)](https://docs.gradle.org/current/userguide/task_configuration_avoidance.html#eager_apis_to_avoid) also this the lint : 
…157295) flutter/engine@de569ba...5eb21d2 2024-10-21 [email protected] [Impeller] Reland: one descriptor pool per frame. (flutter/engine#55960) 2024-10-21 [email protected] Scribe (Android stylus handwriting text input) (flutter/engine#52943) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…7293) This reverts commit f1f83aa. With flutter/engine#55933 this should not be needed.
…#157300) flutter/engine#55944 should have fixed all flakes and rolled into framework.
Related to https://buganizer.corp.google.com/issues/371020223 See flutter/engine#55591 where I updated the engine android 35 emulator version.
…ter_web_sdk artifacts (#156534) The SourceVisitor uses the engineVersion parameter to determine whether it needs to check for changes to artifacts or if it can assume that artifacts are unmodified from a versioned build of the engine. engineVersion is set based on whether the Artifacts instance sets the isLocalEngine property. CachedLocalWebSdkArtifacts (instantiated when the --local-web-sdk flag is used) was only setting isLocalEngine if --local-engine was also used. This caused the build system to ignore changes to the files in the locally built flutter_web_sdk when using --local-web-sdk alone. This PR renames Artifacts.isLocalEngine to usesLocalArtifacts in order to clarify what it means. It also changes CachedLocalWebSdkArtifacts to always enable usesLocalArtifacts.
…157302) flutter/engine@5eb21d2...d302cc9 2024-10-21 [email protected] Revert "[web:a11y] make header a proper <header> (#55747)" (flutter/engine#55993) 2024-10-21 [email protected] [web] implement selectable semantics (flutter/engine#55970) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Useful in tooling, releases, etc - where Dart is available Example usages: ```bash # Monorepo world ❯ dart ./dev/tools/bin/engine_hash.dart -s head 226e13826c7253c968d798666f323b1f207979f8 # Non-monorepo world ❯ dart ./dev/tools/bin/engine_hash.dart -s head Error calculating engine hash: Not in a monorepo ```
…157314) flutter/engine@d302cc9...b3e227b 2024-10-22 [email protected] update the SoT location for package:http_parser (flutter/engine#55998) 2024-10-21 [email protected] Reland: [fuchsia] Remove pm use in build_fuchsia_artifacts (flutter/engine#55932) 2024-10-21 [email protected] Roll Dart SDK from 10387c3fc6d4 to 86ac62245577 (1 revision) (flutter/engine#55995) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows build_tests_7_8"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20build_tests_7_8%22).
This test can be marked as unflaky.
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows build_tests_5_8"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20build_tests_5_8%22).
This test can be marked as unflaky.
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows build_tests_4_8"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20build_tests_4_8%22).
This test can be marked as unflaky.
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows build_tests_3_8"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20build_tests_3_8%22).
This test can be marked as unflaky.
…7409) <!-- meta-tags: To be used by the automation script only, DO NOT MODIFY. { "name": "Linux build_android_host_app_with_module_aar" } --> The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux%20build_android_host_app_with_module_aar%22). This test can be marked as unflaky.
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac build_android_host_app_with_module_aar"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac%20build_android_host_app_with_module_aar%22).
This test can be marked as unflaky.
…157419) <!-- meta-tags: To be used by the automation script only, DO NOT MODIFY. { "name": "Windows build_android_host_app_with_module_aar" } --> The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Windows%20build_android_host_app_with_module_aar%22). This test can be marked as unflaky.
…tter.xcframework.dSYM` into the `App.framework` folder. (#157394) Fixes #157359 Prevents Flutter.xcframework.dSYM from being copied into the App.framework folder. I am not 100% positive if there are cases where it's valid to have multiple dSYMs in that folder, so I'm just string matching and filtering out `Flutter.xcframework.dSYM`
…157478) flutter/engine@73c54fa...5d7caf7 2024-10-23 [email protected] Delete v1 android engine embedding (flutter/engine#52022) 2024-10-23 [email protected] [ios][platform_view]force reset forwarding recognizer state when its stuck (flutter/engine#55958) 2024-10-23 [email protected] Allow running the YAPF formatter using Python version 3.11 (flutter/engine#56062) 2024-10-23 [email protected] [Impeller] optimize clip rects by checking if integral coverage is sufficient. (flutter/engine#56041) 2024-10-23 [email protected] Switch the web compilation step to use an AOT snapshot (flutter/engine#56040) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…157486) flutter/engine@5d7caf7...0b56cb8 2024-10-24 [email protected] Bare-bones iOS FKA implementation (flutter/engine#55964) 2024-10-23 [email protected] [Impeller] libImpeller: Allow appending to the transformation stack. (flutter/engine#56072) 2024-10-23 [email protected] Add standalone 'Mac clangd' builder to replace 'Linux mac_clangd' orchestrator (flutter/engine#56014) 2024-10-23 [email protected] Roll Dart SDK from 75c42f30af7a to dd06a1e3002c (2 revisions) (flutter/engine#56070) 2024-10-23 [email protected] Roll Skia from 42f9070e6625 to 53c9663c3b83 (1 revision) (flutter/engine#56069) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…157488) flutter/engine@0b56cb8...be56084 2024-10-24 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[display_list] grow display list backing store by power of two. (#56004)" (flutter/engine#56078) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Contributes to #130459 It adds a test for - `examples/api/test/painting/star_border/star_border.0_test.dart`
### Summary Add the ability to configure enabled or disabled segments in CupertinoSegmentedControl. The idea is to pass a `segmentStates` map, where the user can set the state according to segment key. User can also set background and text colors when the segment is disabled. ### Demo https://github.com/user-attachments/assets/4a02da02-a0fb-4ded-a271-033a8dc79ac3 ### Related issue Fixes #52105
…157504) flutter/engine@be56084...246344f 2024-10-24 [email protected] Roll Dart SDK from 024c9570fae4 to 7d218a25e8bf (1 revision) (flutter/engine#56085) 2024-10-24 [email protected] Roll Dart SDK from dd06a1e3002c to 024c9570fae4 (1 revision) (flutter/engine#56079) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…` file. (#157388)" (#157541) Reverts: #157388 Initiated by: matanlurey Reason for reverting: We have `--fatal-warnings` on postsubmit and this breaks the tree. Original PR Author: matanlurey Reviewed By: {reidbaker} This change reverts the following previous change: Work towards #48918. This file was soft deprecated in _2020_, but the code was never removed. This warning message will serve as a warning and we'll rip out support for `flutter-plugins` after the _next_ stable release (i.e. after the mid-November branch cut).
Add a partial test for running `flutter build ios-framework` on a regular app project (not a module). Follow-up to this conversation: https://github.com/flutter/flutter/pull/157393/files#r1811810540 Part of #146957
flutter/packages@5e03bb1...a556f0f 2024-10-24 [email protected] [camera] Manual roll and skip failing tests (flutter/packages#7891) 2024-10-23 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.annotation:annotation from 1.8.2 to 1.9.0 in /packages/image_picker/image_picker_android/android (flutter/packages#7898) 2024-10-23 49699333+dependabot[bot]@users.noreply.github.com [url_launcher]: Bump androidx.annotation:annotation from 1.8.2 to 1.9.0 in /packages/url_launcher/url_launcher_android/android (flutter/packages#7906) 2024-10-23 [email protected] [pigeon] Allows swift generator to skip error class generation (flutter/packages#7849) 2024-10-23 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump androidx.annotation:annotation from 1.8.2 to 1.9.0 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#7903) 2024-10-23 49699333+dependabot[bot]@users.noreply.github.com [file_selector]: Bump androidx.annotation:annotation from 1.8.2 to 1.9.0 in /packages/file_selector/file_selector_android/android (flutter/packages#7900) 2024-10-23 [email protected] [video_player_android] Give `can pause` integration test range to test for (flutter/packages#7913) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…r-plugins` file. (#157388)" (#157541)" (#157549) Reverts: #157541 Initiated by: matanlurey Reason for reverting: Was _not_ the cause of failure, see #157542. Original PR Author: auto-submit[bot] Reviewed By: {fluttergithubbot} This change reverts the following previous change: Reverts: #157388 Initiated by: matanlurey Reason for reverting: We have `--fatal-warnings` on postsubmit and this breaks the tree. Original PR Author: matanlurey Reviewed By: {reidbaker} This change reverts the following previous change: Work towards #48918. This file was soft deprecated in _2020_, but the code was never removed. This warning message will serve as a warning and we'll rip out support for `flutter-plugins` after the _next_ stable release (i.e. after the mid-November branch cut).
…t`. (#157527) Work towards #48918. Workaround for #157391 (see #157393 (comment)). I'll run all post-submit tasks as well on this PR using `test: all`.
…157544) flutter/engine@246344f...48ff670 2024-10-24 [email protected] Remove 'Linux mac_clangd' in favor of 'Mac clangd' (flutter/engine#56082) 2024-10-24 [email protected] Added thread name to pipeline validation error. (flutter/engine#56074) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
I recently noticed the following log when building an app in verbose mode: ``` This Android Gradle plugin (8.1.0) was tested up to compileSdk = 33 (and compileSdkPreview = "UpsideDownCakePrivacySandbox"). You are strongly encouraged to update your project to use a newer Android Gradle plugin that has been tested with compileSdk = 35. ``` It looks like AGP would like us to use a newer AGP version if we want to use compileSdk 35 (which we do). This pr upgrades the tests, in advance of updating the templates.
These started flaking and I don't know why. Mark as bringup until we can investigate.
…" (#157559) Reverts: #157032 Initiated by: gmackall Reason for reverting: #157032 (comment) Original PR Author: gmackall Reviewed By: {reidbaker, bartekpacia} This change reverts the following previous change: I recently noticed the following log when building an app in verbose mode: ``` This Android Gradle plugin (8.1.0) was tested up to compileSdk = 33 (and compileSdkPreview = "UpsideDownCakePrivacySandbox"). You are strongly encouraged to update your project to use a newer Android Gradle plugin that has been tested with compileSdk = 35. ``` It looks like AGP would like us to use a newer AGP version if we want to use compileSdk 35 (which we do). This pr upgrades the tests, in advance of updating the templates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )