Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change display name each flavor on debug #1541

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Jaehwa-Noh
Copy link
Contributor

What I have done and why

prodDebug and demoDebug is hardly distinguish each app on the screen.
I changed the app name based on the flavor on debug, except release.

before after
Screenshot_20240711_163737 Screenshot_20240711_191553

Now, we can distinguish both at once glance on the screen.

Change-Id: I5023bab448ae1ac2de74333fd8758a7b0c3c873d
Change-Id: Ia1b6e921a164636aa2b8076af40fa61780cfe0cc
Change-Id: Idc76aba336e5f15bd3cdd808651b190e5992d82c
Change-Id: If99be35af19eddf6a918c00d47ba3ca60139a04b
Change-Id: Icb5455a4887cc8cab9e6ebcc6ad4751343238cc6
Change-Id: Ia3dbd7e805ad02c00fe24fbe0e06a9fb3fdf3976
@@ -37,7 +37,6 @@ kotlin.code.style=official

# Disable build features that are enabled by default,
# https://developer.android.com/build/releases/gradle-plugin#default-changes
android.defaults.buildfeatures.resvalues=false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO re-enabling resValues for that is not good. We already have specific sourceSet for all flavors.
Also, I'm not sure that Prod variant is actually expected to be installed by regular devs, since it needs production keys etc.
This makes the actual Demo app name appearance worse.

Copy link
Contributor Author

@Jaehwa-Noh Jaehwa-Noh Jul 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonMarquis
It seems hard it to do with resValue from the error logs. I can do same thing with another way without resValues.
Before refactor that, I also wonder prod usage, this project just needs the prodRelease?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants