[JetNews] Removes sharedTest trick and Robolectric (#1468)

android · Sep 23, 2024 · d5b5ec0 · d5b5ec0
2 parents 4e2918a + 16514f4
commit d5b5ec0
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 38 deletions.
diff --git a/JetNews/app/build.gradle.kts b/JetNews/app/build.gradle.kts
@@ -60,24 +60,6 @@ android {
         }
     }
 
-    testOptions {
-        unitTests {
-            isReturnDefaultValues = true
-            isIncludeAndroidResources = true
-        }
-    }
-
-    // Tests can be Robolectric or instrumented tests
-    sourceSets {
-        val sharedTestDir = "src/sharedTest/java"
-        getByName("test") {
-            java.srcDir(sharedTestDir)
-        }
-        getByName("androidTest") {
-            java.srcDir(sharedTestDir)
-        }
-    }
-
     compileOptions {
         sourceCompatibility = JavaVersion.VERSION_17
         targetCompatibility = JavaVersion.VERSION_17
@@ -146,11 +128,5 @@ dependencies {
     androidTestImplementation(libs.kotlinx.coroutines.test)
     androidTestImplementation(libs.androidx.compose.ui.test)
     androidTestImplementation(libs.androidx.compose.ui.test.junit4)
-    // Robolectric dependencies
-    testImplementation(libs.androidx.compose.ui.test.junit4)
-    testImplementation(libs.robolectric)
 }
 
-tasks.withType<Test>().configureEach {
-    systemProperties.put("robolectric.logging", "stdout")
-} 
diff --git a/...va/com/example/jetnews/HomeScreenTests.kt → ...va/com/example/jetnews/HomeScreenTests.kt b/...va/com/example/jetnews/HomeScreenTests.kt → ...va/com/example/jetnews/HomeScreenTests.kt
diff --git a/.../java/com/example/jetnews/JetnewsTests.kt → .../java/com/example/jetnews/JetnewsTests.kt b/.../java/com/example/jetnews/JetnewsTests.kt → .../java/com/example/jetnews/JetnewsTests.kt
@@ -16,25 +16,29 @@
 
 package com.example.jetnews
 
+import androidx.activity.ComponentActivity
+import androidx.compose.ui.test.ExperimentalTestApi
 import androidx.compose.ui.test.hasText
-import androidx.compose.ui.test.junit4.createComposeRule
+import androidx.compose.ui.test.junit4.createAndroidComposeRule
 import androidx.compose.ui.test.onNodeWithContentDescription
 import androidx.compose.ui.test.onNodeWithText
 import androidx.compose.ui.test.onRoot
 import androidx.compose.ui.test.performClick
 import androidx.compose.ui.test.printToString
 import androidx.test.core.app.ApplicationProvider
 import androidx.test.ext.junit.runners.AndroidJUnit4
+import com.example.jetnews.data.posts.impl.manuel
 import org.junit.Before
 import org.junit.Rule
 import org.junit.Test
 import org.junit.runner.RunWith
 
+@OptIn(ExperimentalTestApi::class)
 @RunWith(AndroidJUnit4::class)
 class JetnewsTests {
 
     @get:Rule
-    val composeTestRule = createComposeRule()
+    val composeTestRule = createAndroidComposeRule<ComponentActivity>()
 
     @Before
     fun setUp() {
@@ -44,14 +48,16 @@ class JetnewsTests {
 
     @Test
     fun app_launches() {
-        composeTestRule.onNodeWithText("Top stories for you").assertExists()
+        composeTestRule
+            .onNodeWithText(composeTestRule.activity.getString(R.string.home_top_section_title))
+            .assertExists()
     }
 
     @Test
     fun app_opensArticle() {
 
         println(composeTestRule.onRoot().printToString())
-        composeTestRule.onAllNodes(hasText("Manuel Vivo", substring = true))[0].performClick()
+        composeTestRule.onAllNodes(hasText(manuel.name, substring = true))[0].performClick()
 
         println(composeTestRule.onRoot().printToString())
         try {
@@ -69,7 +75,6 @@ class JetnewsTests {
             useUnmergedTree = true
         ).performClick()
         composeTestRule.onNodeWithText("Interests").performClick()
-        // TODO - this fails on CI but not locally. (https://github.com/android/compose-samples/issues/1442)
-        // composeTestRule.waitUntilAtLeastOneExists(hasText("Topics"), 5000L)
+        composeTestRule.waitUntilAtLeastOneExists(hasText("Topics"), 5000L)
     }
 }
diff --git a/...a/com/example/jetnews/TestAppContainer.kt → ...a/com/example/jetnews/TestAppContainer.kt b/...a/com/example/jetnews/TestAppContainer.kt → ...a/com/example/jetnews/TestAppContainer.kt
diff --git a/...st/java/com/example/jetnews/TestHelper.kt → ...st/java/com/example/jetnews/TestHelper.kt b/...st/java/com/example/jetnews/TestHelper.kt → ...st/java/com/example/jetnews/TestHelper.kt
diff --git a/JetNews/app/src/test/resources/robolectric.properties b/JetNews/app/src/test/resources/robolectric.properties