Fix CI and Makefiles to handle dockerfile submodule dependencies. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -54,8 +54,6 @@ jobs: | |||
| run: make docker-dash-p4c | |||
| - name: Build P4 software switch (bmv2) and P4Info | |||
| run: DOCKER_FLAGS=$docker_fg_flags make p4 | |||
| - name: Install DASH submodules recursively | |||
There was a problem hiding this comment.
I've made the same change in two other CI files. I believe that should be reverted as well.
There was a problem hiding this comment.
Please back the changes out and we'll verify one more time with a clean local build and in CI (which is similar to a clean local build).
| @@ -54,8 +54,6 @@ jobs: | |||
| run: make docker-dash-p4c | |||
| - name: Build P4 software switch (bmv2) and P4Info | |||
| run: DOCKER_FLAGS=$docker_fg_flags make p4 | |||
| - name: Install DASH submodules recursively | |||
| run: git submodule update --init --recursive | |||
There was a problem hiding this comment.
This was git submodule update --init before my changes with the comment SAI submodule update. Not sure whether it's still needed..
There was a problem hiding this comment.
I think it isn't needed anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the changes which resulted in successful "make all" locally as well as CI pipeline.