Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a new map provider API which enables not to know maps at compile-time #194

Merged
merged 4 commits into from
Jan 6, 2024

Conversation

qnga
Copy link
Contributor

@qnga qnga commented May 13, 2022

Related to #182.

This new API will enable to develop a plugin letting users select maps of interest from a built-in repository, and even provide their own WMTS URLs.

@qnga
Copy link
Contributor Author

qnga commented Jul 5, 2022

Hello,
Do you plan to review this PR? I've got my plugin basically ready for publishing. It wouldn't make much sense if it's not compatible with a published Trekarta build though.

@StrikeLines
Copy link

We are also very interested in using this PR to view WMTS. Any plans to merge it with production?

@andreynovikov
Copy link
Owner

If you are still interested, I will work on that.

@qnga
Copy link
Contributor Author

qnga commented Dec 20, 2023

I am still interested!

@andreynovikov
Copy link
Owner

Ok, can you fix conflicts as I've made many changes to MainActivity.java since that. And can you also explain what you mean by "not to know maps at compile-time"? This is about plugin compilation, yes?

@andreynovikov
Copy link
Owner

Also I would prefer if you will rewrite current providers instead of introducing new ones. As all current plugins are written by me: https://github.com/andreynovikov/trekarta-online-maps I would rather update them to conform with new API.

@andreynovikov
Copy link
Owner

May be you also have any idea on this?

@qnga
Copy link
Contributor Author

qnga commented Dec 27, 2023

And can you also explain what you mean by "not to know maps at compile-time"? This is about plugin compilation, yes?

Yes, with my API, maps are not necessarily known when you compile the plugin app. That enables plugin apps to let users choose maps they are interested in and provide service keys for them.

I'll update the PR soon.

@qnga
Copy link
Contributor Author

qnga commented Dec 29, 2023

Done. I merged master and removed the old map provider API.

As to tile expiration, I guess we could use HTP cache-control headers. I don't think that would be related to plugins though, as they provide URLs for tiles rather than doing any request themselves.

@andreynovikov andreynovikov merged commit 66393a6 into andreynovikov:master Jan 6, 2024
7 checks passed
@qnga qnga deleted the feature/new-plugin-api branch February 5, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants