Test and fix reordering of positions. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bchronology()output age and position were getting shuffled when the input data were not ordered by position. For instance, a surface sample in my data was given a depth corresponding to another sample in the output. Reordering my data frame by position fixed this.Looking into the code, I think
predictPositionswas getting created before the data were reordered by position, causing the indexing issue. Doing the reordering first seems to fix the error. I did not thoroughly check that this move doesn't change anything else.I added a test for this, but
testthatdoesn't like that I'm running code that produces the reordering warning outside of a test.