Skip to content

Commit

Permalink
[Security Solution] [AI Insights] Remove secondary loading placeholder (
Browse files Browse the repository at this point in the history
elastic#181486)

## [Security Solution] [AI Insights] Remove secondary loading placeholder

### Summary

This PR removes the secondary loading placeholder, per the _before_ and _after_ screenshots below:

#### Before

![before](https://github.com/elastic/kibana/assets/4459398/f9e5a61f-16c8-49e9-aba5-ff5f75ca6bd5)

#### After

![after](https://github.com/elastic/kibana/assets/4459398/22ca8d3b-9b28-473c-aace-d4fcb59d168c)

### Feature flag

The `assistantAlertsInsights` feature flag must be enabled to access this feature:

```
xpack.securitySolution.enableExperimental: ['assistantAlertsInsights']
```
  • Loading branch information
andrew-goldstein authored Apr 23, 2024
1 parent 3142f1a commit 8dcaefc
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 52 deletions.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ import {
showSummary,
} from './helpers';
import { Insight } from '../insight';
import { LoadingPlaceholder } from '../insight/loading_placeholder';
import { LoadingCallout } from './loading_callout';
import { PageTitle } from './page_title';
import { Summary } from './summary';
Expand Down Expand Up @@ -191,15 +190,11 @@ const AiInsightsComponent: React.FC = () => {
isLoading,
loadingConnectorId,
}) ? (
<>
<LoadingCallout
alertsCount={knowledgeBase.latestAlerts}
connectorIntervals={connectorIntervals}
approximateFutureTime={approximateFutureTime}
/>
<EuiSpacer size="m" />
<LoadingPlaceholder />
</>
<LoadingCallout
alertsCount={knowledgeBase.latestAlerts}
approximateFutureTime={approximateFutureTime}
connectorIntervals={connectorIntervals}
/>
) : (
selectedConnectorInsights.map((insight, i) => (
<React.Fragment key={insight.id}>
Expand Down

0 comments on commit 8dcaefc

Please sign in to comment.