Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device: Ecowitt - GW2001 #2435

Merged
merged 3 commits into from
Nov 24, 2024
Merged

Device: Ecowitt - GW2001 #2435

merged 3 commits into from
Nov 24, 2024

Conversation

github-actions[bot]
Copy link
Contributor

This pull request adds the device information for:
Manufacturer: Ecowitt
Model: GW2001
Model ID:
Hardware:
Battery: 2x AA
It closes issue #2434

If Battery Notes is useful to you please
"Buy Me A Coffee"

@andrew-codechimp
Copy link
Owner

The EcoWitt GW2001 is a gateway, it does not take batteries.
Since you can add multiple devices to the gateway it's not possible to have this discovered, instead you should add Entity Battery Notes manually to each device on the hub.

@andrew-codechimp andrew-codechimp merged commit 112e1c9 into main Nov 24, 2024
@andrew-codechimp andrew-codechimp deleted the device-ecowitt_gw2001 branch November 24, 2024 09:26
andrew-codechimp added a commit that referenced this pull request Nov 24, 2024
* Update device: GW2001 by Ecowitt

* Update library.json

* Apply automatic changes

---------

Co-authored-by: mehuman <[email protected]>
Co-authored-by: Andrew Jackson <[email protected]>
Co-authored-by: andrew-codechimp <[email protected]>
andrew-codechimp added a commit that referenced this pull request Nov 24, 2024
* Entity

* Description class inheritance

* Duplicate definition

* Attributes

* Missing service return

* Service param typing

* Entity registry updated

* Template sensor

* Config flow title

* Store

* init

* Repairs

* Typing

* Typing

* Typing

* Check wrapped_battery

* Typing

* Add dev version suffix to non github packaged versions

* Bump HA min version to 2024.10

* Update device: Smart door and window sensor (ZSS-JM-GWM-C-MS) by Moes (#2418)

* Apply automatic changes

* Update events documentation

* Fix doc links

* Fix docs links

* New Crowdin translations by GitHub Action (#2420)

Co-authored-by: Crowdin Bot <[email protected]>

* Update device: MCCGQ02HL by Xiaomi (#2422)

* Apply automatic changes

* New Crowdin translations by GitHub Action (#2424)

* New Crowdin translations by GitHub Action (#2425)

Co-authored-by: Crowdin Bot <[email protected]>

* Adjusting the battery type for the QingPing CGG1 temp sensor (#2427)

* New Crowdin translations by GitHub Action (#2429)

Co-authored-by: Crowdin Bot <[email protected]>

* Update device: Model A by Waveshare (#2431)

Co-authored-by: uvjim <[email protected]>

* Apply automatic changes

* Update device: Meter by SwitchBot (#2433)

* Apply automatic changes

* New Crowdin translations by GitHub Action (#2436)

* Device: Ecowitt - GW2001 (#2435)

* Update device: GW2001 by Ecowitt

* Update library.json

* Apply automatic changes

---------

Co-authored-by: mehuman <[email protected]>
Co-authored-by: Andrew Jackson <[email protected]>
Co-authored-by: andrew-codechimp <[email protected]>

* Update device: Duette by Hunter Douglas by Hunter Douglas (#2438)

Co-authored-by: marinus61 <[email protected]>

* Apply automatic changes

* Typing

# Conflicts:
#	custom_components/battery_notes/library_updater.py

# Conflicts:
#	custom_components/battery_notes/library.py

* Fix library url

* Change to R2 URL

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: andrew-codechimp <[email protected]>
Co-authored-by: Crowdin Bot <[email protected]>
Co-authored-by: Jordan Zucker <[email protected]>
Co-authored-by: uvjim <[email protected]>
Co-authored-by: mehuman <[email protected]>
Co-authored-by: marinus61 <[email protected]>
@mehuman
Copy link
Contributor

mehuman commented Nov 25, 2024

Thanks! I added it manually.

It looks like the GW2000 is just the hub and GW2001 is the set of hub and WX90 sensor
https://shop.ecowitt.com/products/gw2000
https://www.ecowitt.com/shop/goodsDetail/245#

Would it be possible to auto discover the WX90 sensor? Mine is reporting as WH90 Battery with a voltage level.
https://shop.ecowitt.com/products/ws90

@andrew-codechimp
Copy link
Owner

I have Ecowitt devices myself and it is annoying it's grouped all the devices under the hub.
It's not possible to auto discover these sensors as they don't have a manufacturer/model in their own right.

@mehuman
Copy link
Contributor

mehuman commented Nov 25, 2024

Understood. The original issue I submitted was based in the though that my model might have been missing from the library.md. There are quite a few ecowitt models there and a couple have their battery type listed. An example is the GW1100X which runs on USB
https://shop.ecowitt.com/products/gw1100

I'm not sure if that needs to be cleaned up or what that would look like.

Thanks for all the hard work around this! It's vital to my HA install!

@andrew-codechimp
Copy link
Owner

Ah, those must have sneaked through without me noticing, probably before I had an Ecowitt myself, I'll set those to manual as well.

Really the integration or Ecowitt2MQTT needs rewriting to publish each device separately with the gateway acting as a via device, this is something that wasn't supported originally so the integration developers haven't gone back and looked at it since, it would also create a migration nightmare for those with the integration already.

Thanks for the kind words, good to see so many people getting value from this little project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants