Skip to content
This repository has been archived by the owner on Aug 14, 2021. It is now read-only.

Drop any tags from h1 #77

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Drop any tags from h1 #77

wants to merge 2 commits into from

Conversation

orwoods
Copy link

@orwoods orwoods commented Feb 5, 2019

No description provided.

@coveralls
Copy link

coveralls commented Feb 5, 2019

Coverage Status

Coverage decreased (-0.1%) to 97.309% when pulling 9672a55 on IvanPakhomov:master into 23f2175 on andreskrey:master.

@andreskrey
Copy link
Owner

Hi Ivan,

Thank you for your pull request. Mind explaining what you're trying to accomplish with this and also submitting a test case?

@orwoods
Copy link
Author

orwoods commented Feb 7, 2019

Hi!
Sometimes I have to parse the site with this html. There, for some reason, the first letter of the title is duplicated (see screenshot). As a result, the title is: "EExample title".
I think that the useful part of the header (inside h1) should not be inside nested tags like span. Correct me if I am wrong.
2019-02-07 8 38 14

@andreskrey
Copy link
Owner

Can you submit a test case for this and share a real website where this happens? I'd like to see how the js version processes it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants