forked from dimsemenov/PhotoSwipe
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] Allow long captions #1
Closed
Closed
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
2c3e794
website: Fix inline style and indentation (mix of spaces and tabs).
PeterSweetAndSour fa8dc3f
Rename framework.createEl to framework.createElement for clarity
PeterSweetAndSour 21ae260
Question about fake caption container
PeterSweetAndSour 203a335
Rename function argument of a DOM node from 'captionEl' to 'captionEl…
PeterSweetAndSour c3e971e
Add some extra whitespace to separate functions.
PeterSweetAndSour af9e8d7
Rename options to make clear that these are booleans, not DOM elements.
PeterSweetAndSour e71b030
Capture the calculated size of the image and set an option for the ca…
PeterSweetAndSour e0aa68d
Move new option to the UI file.
PeterSweetAndSour 14b3c72
Fix whitespace in photoswipe-ui-default.js. Add some explanatory comm…
PeterSweetAndSour bfb2560
First pass with something that works. Need to fix z-index on captionE…
PeterSweetAndSour 140bdce
Add some lines to seperate functions
PeterSweetAndSour 1d3b1c7
Rename button to be consistent pattern with others. Fix z-index issue…
PeterSweetAndSour 940d898
Fix display/hiding of expand control when switching photos.
PeterSweetAndSour dfe1ec5
Set data attributes on .pswp__item to carry initial image height and …
PeterSweetAndSour dcf9926
Rename function to indicate that it is private.
PeterSweetAndSour 38d5dfb
Save so far now that positioning is correct. Need to fix hiding and s…
PeterSweetAndSour 398619a
Somewhat closer. Accounting for scale but only on first load. :-( Cap…
PeterSweetAndSour dcf57fd
Seems to work.
PeterSweetAndSour ef3c99d
Stop accidental scroll on close. Add a box at the end of the caption …
PeterSweetAndSour 7048891
Various fixes
PeterSweetAndSour 5da7317
Sorted out weirdness with tap behavior. Now preventing closing when t…
PeterSweetAndSour 61e5806
Renaming option name and removing redundant code.
PeterSweetAndSour 3fcd840
Drag up on collapsed caption will expand it.
PeterSweetAndSour 44fabb2
Expand and collapse caption with just the mouse wheel. Had to overrid…
PeterSweetAndSour a69fb0b
Run setupDesktopZoom regardless. As noted in the comment, a timing is…
PeterSweetAndSour 6a80c85
Swap out two lines of SVG for two dozen lines of CSS to make the expa…
PeterSweetAndSour e47f580
Back to SVG background images but now Base64 encoded and background s…
PeterSweetAndSour b3d4525
Reset default for allowLongCaptions to false.
PeterSweetAndSour e98d6c0
Ensure HTML exists for caption control and change title on button whe…
PeterSweetAndSour d6f50fe
Allow left/right buttons to show above expanded caption overlay when …
PeterSweetAndSour 510d5ae
Now with keyboard control.
PeterSweetAndSour e945a8a
Moving the setting of tabindex and focus on the innerCaptionElement t…
PeterSweetAndSour a275376
Animate expansion and collapse of caption.
PeterSweetAndSour 5b52d5d
Get around cross-site security issue by creating a new stylesheet rat…
PeterSweetAndSour d4e2d1d
A bit of rearrangement as I discovered that dragging to a new photo o…
PeterSweetAndSour c67b066
Increase the width of the caption if long captions are selected.
PeterSweetAndSour 78c88f1
Added section for caption expand/collapse by vertical swipe/drag.
PeterSweetAndSour b02454a
Add "FYI" to console notices explaining that two options are overridd…
PeterSweetAndSour d40b745
Remove some console output
PeterSweetAndSour File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
L507 + 508 remove