Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typ - Buscador de turnos y prestaciones - privacidad #2956

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Typ - Buscador de turnos y prestaciones - privacidad #2956

wants to merge 2 commits into from
+9 −6

Conversation

JuanIRamirez
Copy link
Contributor

@JuanIRamirez JuanIRamirez commented Nov 23, 2023 •
edited
Loading

Requerimiento

https://proyectos.andes.gob.ar/browse/TYP-1

Funcionalidad desarrollada

  1. Se agregó @input() verContenido default: true en vistaPrestación.
  2. En turnos-prestaciones.html, componente vista-prestacion [verContenido]="false"

UserStory llegó a completarse

  • Si
  • No
  • No corresponde

Requiere actualizaciones en la base de datos

  • Si
  • No

Requiere actualizaciones en la API

  • Si
  • No

Requiere actualizaciones en andes-test-integracion

  • Si
  • No

@JuanIRamirez JuanIRamirez requested review from a team as code owners November 23, 2023 12:47
@MarianoCampetella
Copy link
Contributor

MarianoCampetella commented Dec 12, 2023 •
edited by Fabio-Ramirez
Loading

Tanto la funcionalidad como el código se encuentran bien, la única duda que me queda es porque se sumaron cambios al package-lock.json? Es necesario tener que subirlo??

Queda corregido.

@silviroa
Copy link
Contributor

USUARIO: mcampetella
BUILD NUMBER: 10048
CYPRESS RUN: 9157
TEST START: 2023-12-12T16:18:31.287Z
TOTAL: 378
SUCCESS: 371
FAIL: 5
SKIPPED: 2

@silviroa
Copy link
Contributor

USUARIO: mcampetella
BUILD NUMBER: 10237
CYPRESS RUN: 9345
TEST START: 2024-01-11T13:46:35.725Z
TOTAL: 401
SUCCESS: 395
FAIL: 3
SKIPPED: 3

@silviroa
Copy link
Contributor

USUARIO: mcampetella
BUILD NUMBER: 10238
CYPRESS RUN: 9346
TEST START: 2024-01-11T13:58:25.326Z
TOTAL: 401
SUCCESS: 397
FAIL: 1
SKIPPED: 3

ma7payne
ma7payne reviewed Jan 11, 2024
View reviewed changes
src/app/modules/rup/components/huds/vistaPrestacion.html Outdated
@@ -77,6 +77,9 @@
<i class="adi {{ elemento | semanticIcon }}"></i>
</div>
<div class="title">
<b *ngIf="!verContenido">
{{ (elemento.esSolicitud) ? 'solicitud' : elemento.concepto.semanticTag}}:&nbsp;
Copy link
Contributor

@ma7payne ma7payne Jan 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Para generar un espacio entre contenidos dinamicos podría utilizarse ${...} ${...} en lugar del caracter ASCII.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corregido!

AgosLizzi
AgosLizzi requested changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@AgosLizzi AgosLizzi left a comment •
edited by Fabio-Ramirez
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La funcionalidad la veo bien. Hay unos minímos detalles visuales:

  • En lo posible posicionar el icono para que quede centrado al relleno de color
    Captura de pantalla 2024-01-11 110124
    Captura de pantalla 2024-01-11 110219
    Captura de pantalla 2024-01-11 110302

  • Lo mismo para el badge que esta dentro del componente
    Captura de pantalla 2024-01-11 110611

Corregido, quedo atento.

@silviroa
Copy link
Contributor

USUARIO: mcampetella
BUILD NUMBER: 10239
CYPRESS RUN: 9347
TEST START: 2024-01-11T14:29:42.599Z
TOTAL: 366
SUCCESS: 355
FAIL: 8
SKIPPED: 3

@MarianoCampetella MarianoCampetella added the changes requested Se solicitaron cambios label Jan 11, 2024
@silviroa
Copy link
Contributor

USUARIO: mcampetella
BUILD NUMBER: 10242
CYPRESS RUN: 9350
TEST START: 2024-01-11T15:36:37.726Z
TOTAL: 311
SUCCESS: 298
FAIL: 10
SKIPPED: 3
⚠️⚠️⚠️⚠️
Hay archivos que no corrieron. Vuelva a intentar.

@silviroa
Copy link
Contributor

USUARIO: mcampetella
BUILD NUMBER: 10276
CYPRESS RUN: 9383
TEST START: 2024-01-16T12:21:21.700Z
TOTAL: 91
SUCCESS: 0
FAIL: 91
SKIPPED: 0
⚠️⚠️⚠️⚠️
Hay archivos que no corrieron. Vuelva a intentar.

@silviroa
Copy link
Contributor

USUARIO: mcampetella
BUILD NUMBER: 10277
CYPRESS RUN: 9384
TEST START: 2024-01-16T12:38:16.838Z
TOTAL: 392
SUCCESS: 389
FAIL: 0
SKIPPED: 3

@silviroa silviroa added test ok Los test estan ok and removed test fail labels Jan 16, 2024
@silviroa
Copy link
Contributor

USUARIO: mcampetella
BUILD NUMBER: 10279
CYPRESS RUN: 9386
TEST START: 2024-01-16T14:48:42.670Z
TOTAL: 380
SUCCESS: 373
FAIL: 4
SKIPPED: 3

@silviroa silviroa added test fail and removed test ok Los test estan ok labels Jan 16, 2024
AgosLizzi
AgosLizzi approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@AgosLizzi AgosLizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gracias @Fabio-Ramirez por corregirlo

@silviroa
Copy link
Contributor

USUARIO: mcampetella
BUILD NUMBER: 10288
CYPRESS RUN: 9395
TEST START: 2024-01-16T18:33:20.695Z
TOTAL: 401
SUCCESS: 399
FAIL: -1
SKIPPED: 3

@silviroa silviroa added test ok Los test estan ok and removed test fail labels Jan 16, 2024
@silviroa
Copy link
Contributor

USUARIO: framirez
BUILD NUMBER: 10319
CYPRESS RUN: 9426
TEST START: 2024-01-22T16:05:10.107Z
TOTAL: 91
SUCCESS: 0
FAIL: 91
SKIPPED: 0
⚠️⚠️⚠️⚠️
Hay archivos que no corrieron. Vuelva a intentar.

@silviroa silviroa added test fail and removed test ok Los test estan ok labels Jan 22, 2024
@silviroa
Copy link
Contributor

USUARIO: framirez
BUILD NUMBER: 10326
CYPRESS RUN: 9433
TEST START: 2024-01-23T11:31:51.411Z
TOTAL: 401
SUCCESS: 398
FAIL: 0
SKIPPED: 3

@silviroa silviroa added test ok Los test estan ok and removed test fail labels Jan 23, 2024
@negro89 negro89 added En pausa Temporalmente pausado and removed changes done labels Jan 23, 2024
@negro89
Copy link
Contributor

negro89 commented Jan 23, 2024

Queda pausado hasta revisar con comision de privacidad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AgosLizzi AgosLizzi AgosLizzi approved these changes

@MarianoCampetella MarianoCampetella MarianoCampetella approved these changes

@MCele MCele Awaiting requested review from MCele MCele is a code owner automatically assigned from andes/code-review

@negro89 negro89 Awaiting requested review from negro89 negro89 is a code owner automatically assigned from andes/code-review

@ma7payne ma7payne Awaiting requested review from ma7payne

@Fabio-Ramirez Fabio-Ramirez Awaiting requested review from Fabio-Ramirez

Assignees

@ma7payne ma7payne

@MarianoCampetella MarianoCampetella

Labels
Aprobado En pausa Temporalmente pausado has_conflicts test ok Los test estan ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@JuanIRamirez @MarianoCampetella @silviroa @negro89 @ma7payne @Fabio-Ramirez @AgosLizzi