RUP - Sobreturnos solo con agenda completa #2891
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarianoCampetella
requested changes
Jul 13, 2023
Comment on lines
499
to
523
| agendaTienePaciente(agenda) { | ||
| let existePaciente = false; | ||
| const lengthBloques = agenda.bloques.length; | ||
| let indexBloque = 0; | ||
| while (indexBloque < lengthBloques && !existePaciente) { | ||
| const _turnos = agenda.bloques[indexBloque].turnos.filter(t => { | ||
| existePaciente = (t.paciente && t.paciente.id) ? true : false; | ||
| }); | ||
| indexBloque++; | ||
| } | ||
| return existePaciente; | ||
| } |
There was a problem hiding this comment.
Una forma de poder resumir un while con un filter es a través del metodo some(). Va un ejemplo:
agendaTienePaciente(agenda) {
return agenda.bloques.some((bloque) => {
return bloque.turnos.some((turno) => {
return turno.paciente && turno.paciente.id;
});
});
}
En caso de utilizarlo como guía dejar un comentario en dicha función para una mejor interpretación!
There was a problem hiding this comment.
Buenas campe! gracias por la sugerencia, queda mas corto es verdad, quedo aplicado con un pequeño comentario. Saludos !
aldoEMatamala
added
changes done
and removed
changes requested
MarianoCampetella
approved these changes
Jul 18, 2023
|
Esperar hasta mediados de agosto para incorporar a prod. |
aldoEMatamala
force-pushed
the
RUP-354
branch
2 times, most recently
from
6f25f27
to
95d39fa
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
maring0019
added
changes requested
maring0019
requested review from
maring0019
and removed request for
maring0019
maring0019
requested review from
maring0019
and removed request for
maring0019
aldoEMatamala
force-pushed
the
RUP-354
branch
from
d4320ba
to
f46c216
Compare
negro89
approved these changes
Oct 31, 2023
|
Tarea momentáneamente bloqueada por otro requerimiento. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requerimiento
https://proyectos.andes.gob.ar/browse/RUP-354
Funcionalidad desarrollada
UserStory llegó a completarse
Requiere actualizaciones en la base de datos
Requiere actualizaciones en la API
Requiere actualizaciones en andes-test-integracion