chunk identifiers to prevent statement with too many placeholders

andersundsehr · Mar 19, 2024 · 984ac27 · 984ac27
1 parent d8cfabc
commit 984ac27
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 24 deletions.
diff --git a/Classes/Command/CleanBoostQueueCommand.php b/Classes/Command/CleanBoostQueueCommand.php
@@ -32,7 +32,7 @@ protected function configure(): void
     /**
      * @throws \Exception
      */
-    protected function execute(InputInterface $input, OutputInterface $output)
+    protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $rows = $this->queueRepository->findError();
         foreach ($rows as $row) {

diff --git a/Classes/Domain/Repository/CacheRepository.php b/Classes/Domain/Repository/CacheRepository.php
@@ -29,8 +29,7 @@ public function findExpiredIdentifiers(): array
             )
             ->groupBy('identifier')
             ->executeQuery()
-            ->fetchFirstColumn()
-        ;
+            ->fetchFirstColumn();
         return $cacheIdentifiers;
     }
 
@@ -44,8 +43,7 @@ public function findAllIdentifiers(): array
             ->from($this->getTableName())
             ->groupBy('identifier')
             ->executeQuery()
-            ->fetchFirstColumn()
-        ;
+            ->fetchFirstColumn();
         return $cacheIdentifiers;
     }
 
@@ -73,28 +71,31 @@ public function findUrlsByIdentifiers(array $identifiers): array
             return [];
         }
 
-        $queryBuilder = $this->createQuery();
-        foreach ($identifiers as &$identifier) {
-            $identifier = $queryBuilder->createNamedParameter($identifier);
-        }
-        unset($identifier);
-
-        $result = $queryBuilder->select('*')
-            ->from($this->getTableName())
-            ->where(
-                $queryBuilder->expr()->in('identifier', $identifiers),
-            )
-            ->execute();
-
         $cacheIdentifiers = [];
-        while ($row = $result->fetchAssociative()) {
-            $content = unserialize($row['content'], ['allowed_classes' => false]);
-            $url = $content['url'] ?? '';
-            if (!$url) {
-                continue;
+
+        foreach (array_chunk($identifiers, 1000) as $chunk) {
+            $queryBuilder = $this->createQuery();
+            foreach ($chunk as &$identifier) {
+                $identifier = $queryBuilder->createNamedParameter($identifier);
             }
+            unset($identifier);
+
+            $result = $queryBuilder->select('*')
+                ->from($this->getTableName())
+                ->where(
+                    $queryBuilder->expr()->in('identifier', $chunk),
+                )
+                ->execute();
+
+            while ($row = $result->fetchAssociative()) {
+                $content = unserialize($row['content'], ['allowed_classes' => false]);
+                $url = $content['url'] ?? '';
+                if (!$url) {
+                    continue;
+                }
 
-            $cacheIdentifiers[$row['identifier']] = $url;
+                $cacheIdentifiers[$row['identifier']] = $url;
+            }
         }
 
         return $cacheIdentifiers;