Add DB v6 support to grype-db-manager #446
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wagoodman
force-pushed
the
update-package-for-v6
branch
from
8c123f6 to
25d1b8a
Compare
wagoodman
force-pushed
the
add-v6-to-manager
branch
from
2a760c8 to
18894c8
Compare
This was referenced Dec 2, 2024
This comment was marked as outdated.
This comment was marked as outdated.
wagoodman
force-pushed
the
update-package-for-v6
branch
from
25d1b8a to
1a79f18
Compare
wagoodman
force-pushed
the
add-v6-to-manager
branch
from
18894c8 to
df150d7
Compare
wagoodman
force-pushed
the
add-v6-to-manager
branch
from
df150d7 to
f9ba254
Compare
wagoodman
force-pushed
the
add-v6-to-manager
branch
3 times, most recently
from
0ee085d to
48566af
Compare
wagoodman
force-pushed
the
v6-enhancements
branch
2 times, most recently
from
e444a5a to
ddfa068
Compare
wagoodman
force-pushed
the
add-v6-to-manager
branch
2 times, most recently
from
0d4a2fd to
2a581d8
Compare
wagoodman
commented
Jan 8, 2025
Comment on lines
28
to
31
| { | ||
| "schema": "6", | ||
| "grype-version": "feat/v6-query-api", | ||
| "supported": false |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
the current plan is to merge this with the dev branch + supported = true
wagoodman
force-pushed
the
add-v6-to-manager
branch
from
f145540 to
4d18088
Compare
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
wagoodman
force-pushed
the
add-v6-to-manager
branch
from
631340c to
cf61307
Compare
Signed-off-by: Alex Goodman <[email protected]>
wagoodman
force-pushed
the
add-v6-to-manager
branch
from
cf61307 to
4c32a7a
Compare
Signed-off-by: Alex Goodman <[email protected]>
wagoodman
force-pushed
the
add-v6-to-manager
branch
from
faaf510 to
dd17d72
Compare
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
kzantow
approved these changes
Jan 17, 2025
| thread.daemon = True | ||
| thread.start() | ||
| try: | ||
| yield latest_url |
There was a problem hiding this comment.
should this have a stop condition or does it automatically get destroyed when done in the with block below?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusts the grype-db-manager to be DB-v6 aware. This also pays down some tech debt by translating the CLI test hardness for the manager to use pytest over the golang bash test harness.
PR stack: