Pass the artifacts checksums in the headers of the deploy request #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @anancarv, could you please take a look at this? it seems like the token for codacy is missing |
|
Hi @anancarv just a friendly reminder that this MR is awaiting review |
anancarv
requested changes
Oct 17, 2024
There was a problem hiding this comment.
Hey @aslheyrr, I just reviewed your PR. But I don't get why you're not using this way of deploying checksums
|
Hi @anancarv, did you see my comments? I'd like to get your feedback so we can move forward with this feature |
- Refactor the existing deploy method to push artifact's checksums
|
hey @anancarv I made some code changes in this branch, could you review them? |
anancarv
previously approved these changes
Nov 11, 2024
anancarv
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Artifactory UI shows a warning message in the uploaded artifacts when artifact checksums aren't provided, therefore we would like to push a checksum of binaries being deployed.
Pushing checksums doesn't seem to be a well documented feature in the JFrog documentation, however here is brief reference to it https://jfrog.com/help/r/why-am-i-getting-client-did-not-publish-a-checksum-value-for-npm-packages/why-am-i-getting-client-did-not-publish-a-checksum-value...-for-npm-packages
Type of change
Please delete options that are not relevant.
How has it been tested ?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist: