Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADRV9008-1 support for HDL with no Tx and ORx components #2263

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

danmois
Copy link
Contributor

@danmois danmois commented Jul 24, 2024

Pull Request Description

ADRV9008-1 support for HDL with no Tx and ORx components.

In the previous approach, the same HDL as for an ADRV9009 was used. This contained Tx path components and the Rx ADXCVR could be modified only by the Tx ADXCVR. In this new version Rx ADXCVR settings are applied through the Rx ADXCVR

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the Coding style guidelines
  • I have performed a self-review of the changes
  • I have commented my code, at least hard-to-understand parts
  • I have build all projects affected by the changes in this PR
  • I have tested in hardware affected projects, at the relevant boards
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe etc), if applies

Call TALISE_setRxTxEnable with parameters extracted from profile
settings.

Signed-off-by: George Mois <[email protected]>
Add ADRV9008-1 support for new HDL not containing components
corresponding to ORx and Tx. The code controlling these components
is removed.

Signed-off-by: George Mois <[email protected]>
@buha
Copy link
Contributor

buha commented Jul 29, 2024

looks good from my point of view, why is it still a draft ?

@danmois
Copy link
Contributor Author

danmois commented Jul 29, 2024

looks good from my point of view, why is it still a draft ?

Waiting to decide on how the HDL project will look like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants