Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding workflow to create Cordio platform docs. #403

Closed
wants to merge 66 commits into from

Conversation

AbbyWolf-ADI
Copy link
Contributor

No description provided.

Copy link
Contributor

@kevin-gillespie kevin-gillespie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can make this platform agnostic. This documentation will apply to all platforms, not just the MAX32655.

We should remove the interfaces that we don't really implement. It looks like we've already excluded most of the un-used interfaces, but we can also remove the audio and codec interfaces.

@kevin-gillespie
Copy link
Contributor

Can we give some names to the anonymous entries?

Copy link
Contributor

@kevin-gillespie kevin-gillespie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good. I'm going to review the README's I moved to make sure we didn't lose significant changes.

@@ -0,0 +1,67 @@
from pathlib import Path
from os import listdir

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this looks for markdown files and PDFs and adds links to USERGUIDE.md?

Maybe we should move this to the workflows folder?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved, but we will have to do a test to double check the new pathing from that file

@@ -1584,6 +1584,12 @@ The Cordio Bluetooth Low Energy (BLE) library provides a full BLE stack for micr
- MAX32680
- MAX32690

#### Cordio Documentation

- [Architecture](ARCHITECTURE.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll have to add a path for these links to work.

Copy link
Contributor Author

@AbbyWolf-ADI AbbyWolf-ADI Feb 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested it a couple different times on my machine, since the workflow copies those files in the same directory as the userguide.md file , pathing like this works fine

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we look at this file in the main branch then the path will be wrong. I don't think we should permanently copy the markdown files into this directory.

sudo make -C Libraries/Cordio/docs/latex

echo "Copying PDF to Cordio/platform/Documentation"
sudo mv Libraries/Cordio/docs/latex/refman.pdf Libraries/Cordio/docs/latex/Cordio-Platform-Documentation.pdf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This filename looks okay, we just need to update what's currently in the PR.

## BLE_hci
Host Controller Interface for controlling Bluetooth Controller devices. Uses a serial port and the HCI interface to send commands and receive events.

```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we double check this is the current help text?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"HCI Tool used to control a Bluetooth Controller through a serial port." is the current help text in the main branch python file, but no README is present there

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you run with the -h parameter and send the help command then we get this help text.

python3 BLE_hci.py -h
python3 BLE_hci.py
help

@kevin-gillespie
Copy link
Contributor

Can we close this?

@Jake-Carter Jake-Carter deleted the cordio-platform-docs branch February 15, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants