-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to use gdk_threads_add_idle instead of gdk_threads_enter/leave #505
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approach seems fine. There are some calls to gdk_threads_enter()/leave() in this file but it's probably due to this PR still being WIP.
My advice is to test this functionality on Windows as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM... As @dNechita pointed out, we need to make sure it works on all supported OSes and to remove all the calls to gdk_threads_enter()/leave() also in the plugins (in a patch per plugin)
|
||
static void set_calibration_progress(GtkProgressBar *pbar, float fraction) | ||
{ | ||
struct set_calibration_progress_params *params = malloc(sizeof(struct set_calibration_progress_params)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: sizeof(*params)
Signed-off-by: Ioan Dragomir <[email protected]>
Signed-off-by: Ioan Dragomir <[email protected]>
…eave Signed-off-by: Ioan Dragomir <[email protected]>
PR Description
necessary to understand them. List any dependencies required for this change.
any space), or simply check them after publishing the PR.
description and try to push all related PRs simultaneously.
PR Type
PR Checklist