Change for adrv9002 sdk26 #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update profiles for API 68.13.7. Signed-off-by: Nuno Sa <[email protected]>
Add an API to only update the gui value of a specific widget. This is useful when we have to do the actual attribute reading before we need to update the GUI. In the next patch, we'll introduce an user of this API. Signed-off-by: Nuno Sa <[email protected]>
With the changes in the device driver API, reading the RSSI on a channel that's not enabled will trow an error. Hence, instead of flooding the device with error's (and the kernel log), don't read the RSSI for channels that are not enabled. With the above, as we always need to read the ensm widget, make use iio_widget_update_value() to update it in case port enable is set to pin (and hence avoiding another call into the device). Signed-off-by: Nuno Sa <[email protected]>
nunojsa
requested review from
cristina-suteu,
dNechita and
mhennerich
as code owners
dNechita
approved these changes
Jun 3, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Support the new adrv9002 device driver API. Changes had to be done for the RSSI widget as now the channel needs to be enabled in order to read it. I'm also introducing a new iio_widget_update_value() widget API which updates the GUI taking the value already read from the device. This is useful to avoid an unnecessary device call when port_en is set to pin (more info in the commit message)
PR Type
PR Checklist