Fix adrv9002 plugin #470
Merged
Fix adrv9002 plugin #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Often, one wants to enable/disable certain features in a plugin depending on the present or not of some attribute. hence, let's add an helper for it. For now, this only supports checking device and channel attributes as that should cover most of the cases. Signed-off-by: Nuno Sa <[email protected]>
Give a more descriptive name on the initial calibrations frame. This will be used in follow change to hide the frame if the feature is not supported. Signed-off-by: Nuno Sa <[email protected]>
If the adrv9002 does not have support (older version) for initial_calibrations handling, the plugin was crashing. Fixing it by making use of the new iio_attr_not_found() helper. If not found, let's hide the calibrations frame and move on with life. While at it, removed useless comment. Signed-off-by: Nuno Sa <[email protected]>
Add missing new line and improving it by stating that the failure might also be from gtk_builder_add_from_file() failing to load the file and not necessarily by the file not being found. Signed-off-by: Nuno Sa <[email protected]>
mhennerich
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small series with some nit improvements and a fix for the adrv9002 plugin.