Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix save feature #458

Merged
merged 4 commits into from
Oct 17, 2023
Merged

Fix save feature #458

merged 4 commits into from
Oct 17, 2023

Conversation

cristina-suteu
Copy link
Contributor

@cristina-suteu cristina-suteu commented Oct 17, 2023 •
edited
Loading

This includes the following fixes:

  • exapand channel list in save_as dialog so all channels are visible
  • use allocation widget to get the position of osc plot window when screenshotting(saving to PNG)
  • check data written to CSV,MAT,VSA files is coming only from input channels
  • make sure only input channels are displayed in save_as list (temporary fix)

cristina-suteu and others added 4 commits October 12, 2023 14:42
@cristina-suteu
glade/oscplot: expand channel selection in save_as dialog
6b9db82 
Signed-off-by: Cristina Suteu <[email protected]>
@cristina-suteu
oscplot: fix save as png
2823740 
correctly get window allocation
pass x and y coordinates to gdk_pixbuf_get_from_window

Signed-off-by: Cristina Suteu <[email protected]>
@mhennerich
oscplot: Fix save as csv/vsa/mat for devices with output channels
c65ab55 
not all channels are input or scan channels, so omit them.

Signed-off-by: Michael Hennerich <[email protected]>
@cristina-suteu
oscplot: ensure channels dispalyed in save dialog are all inputs
938d5a0 
Signed-off-by: Cristina Suteu <[email protected]>
@cristina-suteu cristina-suteu merged commit 584eccc into master Oct 17, 2023
10 checks passed
@cristina-suteu cristina-suteu deleted the fix-save-omit-out-chan branch October 17, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dNechita dNechita dNechita approved these changes

@mhennerich mhennerich mhennerich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cristina-suteu @mhennerich @dNechita