ADD: Project: AD353XR #1544
Open
ADD: Project: AD353XR #1544
+1,050
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actorreno
requested review from
acostina,
AndreiGrozav,
PopPaul2021,
gastmaier and
sarpadi
as code owners
|
RetriggerCI |
actorreno
force-pushed
the
dev_ad353xr
branch
from
5b3dacd to
ef9059d
Compare
actorreno
requested review from
IuliaCMoldovan,
StancaPop and
LBFFilho
as code owners
actorreno
force-pushed
the
dev_ad353xr
branch
from
ef9059d to
89d9143
Compare
|
Updated pull request especially commit format. There are still some missing info in the docu that I am still waiting for requestor to provide. Will update it when possible |
Adding documentation for new project ad353xr Signed-off-by: Alexis Czezar Torreno <[email protected]>
actorreno
force-pushed
the
dev_ad353xr
branch
from
89d9143 to
2d98222
Compare
sarpadi
reviewed
Jan 16, 2025
projects/ad353xr/Makefile
Outdated
| @@ -0,0 +1,7 @@ | |||
| #################################################################################### | |||
| ## Copyright (c) 2018 - 2023 Analog Devices, Inc. | |||
There was a problem hiding this comment.
For all license headers of new files the year should be 2025, no range required. Do this for all the source files
There was a problem hiding this comment.
replaced all years to just 2025
| ### SPDX short identifier: ADIBSD | ||
| ############################################################################### | ||
|
|
||
| set REQUIRED_QUARTUS_VERSION 21.1.0 |
There was a problem hiding this comment.
change required version to 23.1std.1
https://github.com/analogdevicesinc/hdl/blob/main/projects/ad4170_asdz/de10nano/system_project.tcl#L6
There was a problem hiding this comment.
changed the version requirement
|
|
||
| set_instance_assignment -name IO_STANDARD "3.3-V LVTTL" -to dac_resetb | ||
| set_instance_assignment -name IO_STANDARD "3.3-V LVTTL" -to dac_ldacb | ||
|
|
There was a problem hiding this comment.
remove blank lines (where needed, use only one)
Adding ad353xr project for coraz7s Signed-off-by: Alexis Czezar Torreno <[email protected]>
Adding project ad353xr for zedboard Signed-off-by: Alexis Czezar Torreno <[email protected]>
Adding project ad353xr for de10nano Signed-off-by: Alexis Czezar Torreno <[email protected]>
actorreno
force-pushed
the
dev_ad353xr
branch
from
2d98222 to
1a59473
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding new driver or project for AD353XR
PR Description
Adding support for the AD353XR family of low power DACs.
Wikipage for approval:
https://wiki.analog.com/resources/eval/user-guides/ad353xr
Notes on checklist:
No comments much since this is a simple "connect the SPI", no added IPs.
No testbenches used/added.
I updated the wiki and readme. Since this is old code (2yrs ago done), I am unsure what's the latest copyright but I still updated as far as I know.
PR Type
PR Checklist