-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove set_acceleration from all interfaces #994
Conversation
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions. |
I'm not sure if I'm supposed to be reviewing PRs, but why not? Maybe we should discuss that actually, what the process is that we're using. There's a bit of context missing from the description, but I'm guessing from the comment in community/interface/gd.py that this was physically unsound, and is therefore being removed? I'm seeing a few more files with
|
Yes, that's correct. The codes will always overwrite the acceleration, so setting this is misleading.
In these cases it seems to be used in a different way, maybe needs to be addressed but that would be a different PR.
Updated. |
fixes #862