fix: Update mssql extractor to utilize proper case for case sensitive MSSQL databases #2234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct case so mssql extractor works with case sensitive instances
|
Congratulations on your first Pull Request and welcome to Amundsen community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/amundsen-io/amundsen/blob/main/CONTRIBUTING.md) |
innocuous change to add signed off. Signed-off-by: Andrew Neuer <[email protected]>
|
Please check the DCO task above |
|
DCO task should be resolved now, just need review. Thanks |
kristenarmes
approved these changes
Feb 27, 2024
|
@ardcarmvk it seems it got broken again |
I think the issue is the original commit has to be modified to include the sign off, check out the details in the failed task here for instructions |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct SQL code's table and column case so mssql extractor works with case sensitive instances
Description
Some SQL Server databases are configured as case sensitive. Changes were made for utilizing proper case in
required areas.
Motivation and Context
Extractor will not work on mssql databases that are case sensitive
How Has This Been Tested?
Ran the SQL code on SQL database with case sensitivity, tested the extractor against non-case sensitive and case sensitive
databases. Ran on windows 10 with python 3.12 on local machine.
Documentation
CheckList