Skip to content

Commit

Permalink
Merge branch 'main' into support-browser-runner
Browse files Browse the repository at this point in the history
  • Loading branch information
oeway authored Dec 3, 2024
2 parents 52feb2a + 5c96b87 commit 2d5a3c6
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 3 deletions.
1 change: 1 addition & 0 deletions docs/migration-guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ To connect to the server, instead of using the `imjoy-rpc` module, you will need

We also changed our versioning strategy, we use the same version number for the server and client, so it's easier to match the client and server versions. For example, `hypha-rpc` version `0.20.42` is compatible with Hypha server version `0.20.42`.


#### 2. Change the connection method and use camelCase for service function names

In JavaScript, the connection method and service function names use camelCase.
Expand Down
2 changes: 1 addition & 1 deletion hypha/VERSION
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"version": "0.20.42.post2"
"version": "0.20.42 "
}
5 changes: 4 additions & 1 deletion hypha/apps.py
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,10 @@ async def start(
runner = random.choice(await self.get_runners())

full_client_id = workspace + "/" + client_id
metadata = {
await runner.start(
url=local_url, session_id=full_client_id, time_limit=time_limit
)
self._sessions[full_client_id] = {
"id": full_client_id,
"app_id": app_id,
"workspace": workspace,
Expand Down
1 change: 0 additions & 1 deletion hypha/templates/ws/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,6 @@
<div id="app"></div>
<script type="module">
import { HyphaCore } from "https://cdn.jsdelivr.net/npm/[email protected]/dist/hypha-core.mjs";

const defaultService = {
getServerConfig(context){
let token;
Expand Down

0 comments on commit 2d5a3c6

Please sign in to comment.