Skip to content

Commit

Permalink
make lakeformation property optional
Browse files Browse the repository at this point in the history
Signed-off-by: Amardeepsingh Siglani <[email protected]>
  • Loading branch information
amsiglan committed May 30, 2024
1 parent 8da9744 commit d38f3ff
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion common/types/data_connections.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export type DatasourceType = 'S3GLUE' | 'PROMETHEUS';
export interface S3GlueProperties {
'glue.indexstore.opensearch.uri': string;
'glue.indexstore.opensearch.region': string;
'glue.lakeformation.enabled': boolean;
'glue.lakeformation.enabled'?: boolean;
}

export interface PrometheusProperties {
Expand Down
2 changes: 1 addition & 1 deletion public/components/datasources/utils/helpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@ export function checkIsConnectionWithLakeFormation({
connector,
properties,
}: DatasourceDetails): boolean {
return connector === 'S3GLUE' && (properties as S3GlueProperties)['glue.lakeformation.enabled'];
return connector === 'S3GLUE' && !!(properties as S3GlueProperties)['glue.lakeformation.enabled'];
}

0 comments on commit d38f3ff

Please sign in to comment.