Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade Composer to v1 in v2.0 of plugin #5610

Merged
merged 6 commits into from
Nov 19, 2020
Merged

Downgrade Composer to v1 in v2.0 of plugin #5610

merged 6 commits into from
Nov 19, 2020

Conversation

pierlon
Copy link
Contributor

@pierlon pierlon commented Nov 19, 2020

Summary

Reverts changes made in #5601.

Temporarily addresses #5609 until we find a robust solution for the issue.

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2020 •
edited
Loading

Plugin builds for 22f8d27 are ready 🛎️!

@pierlon pierlon added the WS:Core Work stream for Plugin core label Nov 19, 2020
@pierlon pierlon added this to the v2.0.7 milestone Nov 19, 2020
@pierlon pierlon self-assigned this Nov 19, 2020
@westonruter

This comment has been minimized.

Sign in to view
@pierlon
Copy link
Contributor Author

pierlon commented Nov 19, 2020

Automated builds are now working again.

westonruter
westonruter approved these changes Nov 19, 2020
View reviewed changes
Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending testing in AMP Slack.

@westonruter
Copy link
Member

Merging since Travis is taking its sweet time and the only changes reverts.

@westonruter westonruter merged commit 13c4ede into 2.0 Nov 19, 2020
@westonruter westonruter deleted the hotfix/2.0-downgrade-composer branch November 19, 2020 21:35
@westonruter
Copy link
Member

Also, changes have been verified to no longer cause fatal errors.

@westonruter westonruter mentioned this pull request Nov 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter westonruter approved these changes

@schlessera schlessera Awaiting requested review from schlessera

Assignees

@pierlon pierlon

Labels
WS:Core Work stream for Plugin core
Projects
None yet
Milestone
v2.0.7
Development

Successfully merging this pull request may close these issues.
2 participants
@pierlon @westonruter