Normalize frameborder=no|yes to frameborder=0|1 in iframe sanitizer #3064
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2335
The logic to normalize the frameborder attribute is based on the text from https://html.spec.whatwg.org/#frames-and-framesets:
Open questions:
sanitize_boolean_digit()
in theAMP_Base_Sanitizer
parent class, to mirror the behavior ofsanitize_dimension()
which is in there, too. Should the base class regroup such logic that might be needed across sanitizer? Or would it make sense to extract them into either separate helper objects or traits?sanitize_boolean_digit()
... is there a name that is clearer here? Maybe an official HTML "attribute type" name I don't know about?