Skip to content

Commit

Permalink
Ignore Story editor tests (#4043)
Browse files Browse the repository at this point in the history
* Ignore block-editor & stories-editor E2E tests

* Conform to semver updated method signatures

* Fix failing block-editor tests

* Disallow E2E tests to fail
  • Loading branch information
pierlon authored and westonruter committed Jan 10, 2020
1 parent 7473009 commit a7e0497
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 4 deletions.
2 changes: 0 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,6 @@ jobs:
# PHP unit tests (7.4, WordPress trunk)
- env: WP_VERSION=trunk DEV_LIB_ONLY=phpunit INSTALL_PWA_PLUGIN=1
php: 7.4snapshot
# E2E tests, since flaky.
- env: WP_VERSION=latest DEV_LIB_SKIP=phpcs,eslint,xmllint,phpsyntax,phpunit PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=
include:
- stage: lint
name: Lint (PHP, JavaScript, and configuration files)
Expand Down
2 changes: 1 addition & 1 deletion bin/local-env/run-e2e-tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ prc.stdout.on( 'data', ( data ) => {

const testsToIgnore = [];

if ( semver.gte( '5.3.0', semver.coerce( wpVersion ) ) ) {
if ( semver.gte( semver.clean( wpVersion ), '5.3.0' ) ) {
// Ignore tests that are not to be run in WP >= 5.3.0.
testsToIgnore.push( 'AMP Settings Screen should not allow AMP Stories to be enabled when Gutenberg is not active' );
}
Expand Down
1 change: 1 addition & 0 deletions tests/e2e/jest.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ module.exports = {
testPathIgnorePatterns: [
'.git',
'node_modules',
'tests/e2e/specs/stories-editor',
],
reporters: [ [ 'jest-silent-reporter', { useDots: true } ] ],
};
2 changes: 1 addition & 1 deletion tests/e2e/specs/block-editor/featured-image-notice.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ describe( 'Featured Image Notice', () => {
beforeEach( async () => {
await createNewPost( { postType: 'post' } );
await clickButton( 'Document' );
await clickButton( 'Featured Image' );
await clickButton( 'Featured image' );
await clickButton( 'Set featured image' );
} );

Expand Down

0 comments on commit a7e0497

Please sign in to comment.