Merge pull request #8 from amplitude/external-test-2

fix(rrweb): external function errors should be tagged

.changeset/four-gifts-march.md

@@ -0,0 +1,5 @@
+---
+'@amplitude/rrweb': patch
+---
+
+fix(rrweb): external function errors should be tagged

packages/rrweb/src/record/error-handler.ts

@@ -1,6 +1,8 @@
 import type { ErrorHandler } from '../types';
 
 type Callback = (...args: unknown[]) => unknown;
+type GenericFunction = (...args: any[]) => any;
+type ExternalError = Error & { _external_: boolean };
 
 let errorHandler: ErrorHandler | undefined;
 
@@ -34,3 +36,20 @@ export const callbackWrapper = <T extends Callback>(cb: T): T => {
 
   return rrwebWrapped;
 };
+
+export function externalFunctionWrapper<T extends GenericFunction>(
+  func: T,
+): (...args: Parameters<T>) => ReturnType<T> {
+  return (...args: Parameters<T>) => {
+    try {
+      return func(...args);
+    } catch (error) {
+      try {
+        (error as ExternalError)._external_ = true;
+      } catch {
+        // in case we can't assign, don't do anything.
+      }
+      throw error;
+    }
+  };
+}

packages/rrweb/src/record/observer.ts

@@ -47,7 +47,7 @@ import {
   patch,
   throttle,
 } from '../utils';
-import { callbackWrapper } from './error-handler';
+import { callbackWrapper, externalFunctionWrapper } from './error-handler';
 import MutationBuffer from './mutation';
 
 type WindowWithStoredMutationObserver = IWindow & {
@@ -665,7 +665,9 @@ function initStyleSheetObserver(
             adds: [{ rule, index }],
           });
         }
-        return target.apply(thisArg, argumentsList);
+        return externalFunctionWrapper(() =>
+          target.apply(thisArg, argumentsList),
+        )();
       },
     ),
   });
@@ -694,7 +696,9 @@ function initStyleSheetObserver(
             removes: [{ index }],
           });
         }
-        return target.apply(thisArg, argumentsList);
+        return externalFunctionWrapper(() =>
+          target.apply(thisArg, argumentsList),
+        )();
       },
     ),
   });