Use Lark with its cache feature, instead of creating a standalone parser #53

erezsh · 2021-01-12T22:32:46Z

The behavior and performance are the same, but the code is much shorter.

aoskotsky-amplify

Hey, thanks a lot for this PR! This cleans it up a lot.

I noticed tox was failing so committed some lint fixes. I left a couple of questions in the comments. Let me know what you think and we can merge this.

test/unit/test_load.py

aoskotsky-amplify · 2021-01-22T05:13:43Z

hcl2/api.py

@@ -15,4 +15,4 @@ def loads(text: str) -> dict:
 # Lark doesn't support a EOF token so our grammar can't look for "new line or end of file"
 # This means that all blocks must end in a new line even if the file ends
 # Append a new line as a temporary fix
- return hcl2.parse(text + "\n")
+ return hcl2.parse(text + "\n") # type: ignore


mypy was complaining that parse returns a Tree instead of a Dict. We can leave the ignore here but was curious why it does that.

nyurik · 2021-05-05T16:01:39Z

From dev-ops perspective, it would be great if python-hcl2 lib had no external dependencies. Lark is a fairly complex project to do a full security check on, thus reducing the usefulness of this amazing library. My (limited) understanding is that Lark can generate a custom python file for the specific grammar, making the Lark itself not required. Would it be possible to do that? Thanks!

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use Lark with its cache feature, instead of creating a standalone parser #53

Use Lark with its cache feature, instead of creating a standalone parser #53

erezsh commented Jan 12, 2021

aoskotsky-amplify left a comment

aoskotsky-amplify Jan 22, 2021

nyurik commented May 5, 2021 •

edited

Loading

Use Lark with its cache feature, instead of creating a standalone parser #53

Use Lark with its cache feature, instead of creating a standalone parser #53

Conversation

erezsh commented Jan 12, 2021

aoskotsky-amplify left a comment

Choose a reason for hiding this comment

aoskotsky-amplify Jan 22, 2021

Choose a reason for hiding this comment

nyurik commented May 5, 2021 • edited Loading

nyurik commented May 5, 2021 •

edited

Loading