Fixed return type for RedistList::get() (#96)

Expanded allowed types for RedistList::get to include integer.
amphp · Aug 3, 2024 · a1e8cdc · a1e8cdc
1 parent 0b3f38d
commit a1e8cdc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/Command/RedisList.php b/src/Command/RedisList.php
@@ -21,8 +21,10 @@ public function __construct(
 
  /**
  * @link https://redis.io/commands/lindex
+ *
+ * TODO: Change type declaration to int only in next major.
  */
- public function get(string $index): string
+ public function get(string|int $index): ?string
  {
  return $this->client->execute('lindex', $this->key, $index);
  }

diff --git a/test/Command/RedisListTest.php b/test/Command/RedisListTest.php
@@ -51,6 +51,7 @@ public function test(): void
  $this->assertSame('y', $list->popHeadBlocking());
  $this->assertSame('b', $list->popTailBlocking());
 
+ $this->assertNull($this->redis->getList('nonexistent')->get(0));
  $this->assertNull($this->redis->getList('nonexistent')->popHeadBlocking(1));
  $this->assertNull($this->redis->getList('nonexistent')->popTailBlocking(1));
  $this->assertNull($this->redis->getList('nonexistent')->popTailPushHeadBlocking('nonexistent', 1));