Skip to content

Commit

Permalink
Fix loop getting stuck when launching a process fails on Windows (#72)
Browse files Browse the repository at this point in the history
Fixes #51, #71.

Original patch:
Nicodinus@3d41ea5

Co-authored-by: Aleksei Iarovoi <[email protected]>
  • Loading branch information
MatmaRex and Nicodinus authored Apr 19, 2024
1 parent 2cd3805 commit 1949d85
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions lib/Internal/Windows/SocketConnector.php
Original file line number Diff line number Diff line change
Expand Up @@ -365,6 +365,9 @@ public function onProcessConnectTimeout($watcher, Handle $handle)
\proc_close($handle->proc);

$handle->joinDeferred->fail($error);

Loop::cancel($handle->childPidWatcher);
$handle->pidDeferred->fail($error);
}

public function registerPendingProcess(Handle $handle)
Expand Down

0 comments on commit 1949d85

Please sign in to comment.